Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benymng/setup google geoncoding api #130

Merged
merged 6 commits into from
May 17, 2024

Conversation

benymng
Copy link
Contributor

@benymng benymng commented Apr 24, 2024

Notion Ticket Link

Setup Google Geoencoding API

Implementation Description

  • Use the google API to get the longitude and latitude of the onboarding address

Steps To Test

  1. Create an onboarding request and see if the latitude and latitude associated with the user are correct

What Should Reviewers Focus On?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

github-actions bot commented May 17, 2024

Visit the preview URL for this PR (updated for commit 2833adc):

https://feeding-canadian-kids-staging--pr130-benymng-setup-goo-drapwhgt.web.app

(expires Fri, 24 May 2024 06:21:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f3744353be12c99e3df04fa4e0f28b3ad46bf004

Copy link
Contributor

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for working on this and all your other work this term!

I just went ahead and added support for geo specfic error messages passing to the frontend, and also kept the old code behind an env variable incase we even want to switch API's back to that one

@shahanneda shahanneda merged commit 2964079 into main May 17, 2024
4 checks passed
@shahanneda shahanneda deleted the benymng/Setup-Google-Geoncoding-API branch May 17, 2024 07:11
jarydo pushed a commit that referenced this pull request Jun 13, 2024
jarydo pushed a commit that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants