-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benymng/setup google geoncoding api #130
Conversation
Visit the preview URL for this PR (updated for commit 2833adc): https://feeding-canadian-kids-staging--pr130-benymng-setup-goo-drapwhgt.web.app (expires Fri, 24 May 2024 06:21:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f3744353be12c99e3df04fa4e0f28b3ad46bf004 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for working on this and all your other work this term!
I just went ahead and added support for geo specfic error messages passing to the frontend, and also kept the old code behind an env variable incase we even want to switch API's back to that one
--------- Co-authored-by: Shahan Neda <[email protected]>
--------- Co-authored-by: Shahan Neda <[email protected]>
Notion Ticket Link
Setup Google Geoencoding API
Implementation Description
Steps To Test
What Should Reviewers Focus On?
Checklist