Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editing of meal donations. #126

Merged
merged 13 commits into from
May 18, 2024
Merged

Add editing of meal donations. #126

merged 13 commits into from
May 18, 2024

Conversation

jho426
Copy link
Contributor

@jho426 jho426 commented Apr 2, 2024

Notion Ticket Link

Replace with Ticket URL

Implementation Description

  • Implemented the UpdateMealRequestDonation mutation which allows a user to modify the meal_description and additional_info fields of their donation
  • Added a new test for the mutation

Steps To Test

  1. Run make betest

What Should Reviewers Focus On?

  • The logic and functionality of the code

Checklist

  • [✅ ] My PR name is descriptive and in imperative tense
  • [✅ ] My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • [ ✅] I have run the appropriate linter(s)
  • [ ✅] I have added tests for my changes
  • [ ✅] I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jho426 jho426 changed the title update donation info request update donation info request (wip) Apr 24, 2024
@shahanneda shahanneda changed the title update donation info request (wip) Add editing of meal donations. May 18, 2024
Copy link

github-actions bot commented May 18, 2024

Visit the preview URL for this PR (updated for commit af0e267):

https://feeding-canadian-kids-staging--pr126-jho426-update-req-otnr1nqb.web.app

(expires Sat, 25 May 2024 19:49:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f3744353be12c99e3df04fa4e0f28b3ad46bf004

Copy link
Contributor

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this Jacqueline! Congrats on your first BE ticket. Since I was working on donor onsite contacts, I went ahead and added them to this branch, and so I just finished up the PR, so no more work from you is needed for this! Though feel free to improve the form further if you have ideas.

@shahanneda shahanneda merged commit e7254e4 into main May 18, 2024
4 checks passed
@shahanneda shahanneda deleted the jho426/update-request branch May 18, 2024 19:57
jarydo pushed a commit that referenced this pull request Jun 13, 2024
jarydo pushed a commit that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants