Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the upstream test suite in CI (fixes #8) #13

Merged
merged 19 commits into from
Feb 17, 2024

Conversation

oSoMoN
Copy link
Collaborator

@oSoMoN oSoMoN commented Feb 10, 2024

The script takes a shortcut to fetch only the test suite from the upstream repository and carefully avoids running the autotools machinery which is time-consuming and resource-intensive, and doesn't offer the option to not build the upstream binaries.
As a consequence, the environment in which the tests are run might not match exactly that used when the upstream tests are run through the autotools. Whether tests are failing because of an incorrect environment remains to be investigated.

Unsurprisingly a number of tests are failing because of missing options in the current implementation or discrepancy in the output. These will need to be implemented/fixed.

@sylvestre
Copy link
Collaborator

The job should not fail.
And we should generate a json at the end like the coreutils but it can be done in another pr.

Please let me know when it is ready for review

@oSoMoN
Copy link
Collaborator Author

oSoMoN commented Feb 11, 2024

The job should not fail. And we should generate a json at the end like the coreutils but it can be done in another pr.

I tweaked the workflow to not fail when run in CI. I'll look into generating that JSON data as soon as I get a chance.

Please let me know when it is ready for review

Almost there, I would like to allow run-upstream-testsuite.sh to run selected tests only, and to report results more verbosely to ease investigation of failures. I'm converting this PR to draft until it's ready for review.

@oSoMoN oSoMoN marked this pull request as draft February 11, 2024 21:38
@sylvestre
Copy link
Collaborator

Do you think it would be possible to show the errors in the log ? thanks

@oSoMoN oSoMoN force-pushed the run-upstream-testsuite branch from 74fa543 to 76dce3d Compare February 12, 2024 22:37
@oSoMoN oSoMoN force-pushed the run-upstream-testsuite branch from 8d89a9e to fed876b Compare February 13, 2024 20:54
@oSoMoN oSoMoN force-pushed the run-upstream-testsuite branch from 0fb0544 to 3a83bbf Compare February 15, 2024 20:10
@oSoMoN oSoMoN marked this pull request as ready for review February 16, 2024 21:25
@oSoMoN
Copy link
Collaborator Author

oSoMoN commented Feb 16, 2024

I believe this is now ready for review.

Do you think it would be possible to show the errors in the log ? thanks

I added a script that prints out details about every test (including the contents of stdout and stderr) in a markdown format, convenient for filing issues to track tests with an unexpected result. When rendered it looks like this:

test: excess-slash

result: FAIL
url: https://git.savannah.gnu.org/cgit/diffutils.git/tree/tests/excess-slash?id=6c88db1f7bfc25b1480d9876dac25024aa688544

stdout

diff -u /dev/null err
--- /dev/null	1970-01-01
+++ err	1970-01-01
+Error: "Unknown option: r"
--- expected-out	
+++ out	
@@ -1 +0,0 @@
-Only in b/f: g
Not removing temporary directory /tmp/tmp.3jNgxNWI94/diffutils/tests/gt-excess-slash.YClC

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@sylvestre sylvestre merged commit 790ef1e into uutils:main Feb 17, 2024
9 of 14 checks passed
@sylvestre
Copy link
Collaborator

excellent, thanks

@oSoMoN oSoMoN deleted the run-upstream-testsuite branch February 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants