-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run the upstream test suite in CI (fixes #8) #13
Conversation
The job should not fail. Please let me know when it is ready for review |
…t until all tests pass reliably)
I tweaked the workflow to not fail when run in CI. I'll look into generating that JSON data as soon as I get a chance.
Almost there, I would like to allow |
Do you think it would be possible to show the errors in the log ? thanks |
74fa543
to
76dce3d
Compare
8d89a9e
to
fed876b
Compare
0fb0544
to
3a83bbf
Compare
I believe this is now ready for review.
I added a script that prints out details about every test (including the contents of stdout and stderr) in a markdown format, convenient for filing issues to track tests with an unexpected result. When rendered it looks like this: test: excess-slashresult: FAIL stdout
|
excellent, thanks |
The script takes a shortcut to fetch only the test suite from the upstream repository and carefully avoids running the autotools machinery which is time-consuming and resource-intensive, and doesn't offer the option to not build the upstream binaries.
As a consequence, the environment in which the tests are run might not match exactly that used when the upstream tests are run through the autotools. Whether tests are failing because of an incorrect environment remains to be investigated.
Unsurprisingly a number of tests are failing because of missing options in the current implementation or discrepancy in the output. These will need to be implemented/fixed.