fix: Avoid crash when fetching wrong bus or vca #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiertho
force-pushed
the
bugfix/avoid-crash-when-fetching-wrong-bus-or-vca
branch
from
840a209 to
7643e4e
Compare
CedNaru
approved these changes
Nov 14, 2024
CedNaru
reviewed
Nov 14, 2024
src/fmod_cache.cpp
Outdated
| } | ||
|
|
||
| Ref<FmodVCA> FmodCache::get_vca(const String& vcaPath) { | ||
| return vcas.get(strings_to_guid.get(vcaPath)); | ||
| return get_vca(strings_to_guid.get(vcaPath)); |
There was a problem hiding this comment.
Don't you need to check if the string has a matching guid as well ? Otherwise, you will end up with the same kind of crash the guid function had.
piiertho
force-pushed
the
bugfix/avoid-crash-when-fetching-wrong-bus-or-vca
branch
from
7643e4e to
1589b5f
Compare
CedNaru
approved these changes
Nov 14, 2024
piiertho
deleted the
bugfix/avoid-crash-when-fetching-wrong-bus-or-vca
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid crash when fetching wrong bus or vca.