USWDS-Site: Collection Accessibility Checklist #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathybaptista
requested review from
mahoneycm,
amyleadem,
mlloydbixal,
alex-hull and
RachelCorsino
There was a problem hiding this comment.
Looks great @cathybaptista! Just some comments for tiny fixes that I noticed(:
|
@RachelCorsino thank you SO MUCH for such a thorough review! I think these should be good to go. Cheers! |
RachelCorsino
previously approved these changes
Dec 12, 2024
mahoneycm
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Looks good @cathybaptista ! Two updates from what is listed on the checklist. Discussed on teams.
|
Also, can you resolve any comments that are finished to clean up the thread a bit? It'll give us a better snapshot of where this PR is at! |
cathybaptista
force-pushed
the
cb-publish-collection-checklist
branch
from
5c48490 to
70196ea
Compare
amyleadem
requested changes
Dec 12, 2024
amyleadem
previously approved these changes
Dec 13, 2024
mlloydbixal
previously approved these changes
Dec 13, 2024
…blish-collection-checklist
updating changelog
updating changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added accessibility test page for collection component
Important
We need to update changelog dates before merge
Related issue
Closes #2910
Preview link
Collection Component Page
Process List Accessibility Tests Page
Testing and review
Follow these steps:
Manual Tests Run prior to submitting this PR:
git pull origin [base branch]to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch ismain).npm run prettier:scssto format any Sass updates.npm testand confirm that all tests pass.