USWDS-Site - Feature: Add ECAP to Showcase #2839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyleadem
previously approved these changes
Oct 28, 2024
|
Actually, just realized this needs a changelog. I'll go ahead and add it (and might do some backfill on missed changelog entries for this page) |
amyleadem
dismissed
their stale review
Dismissing approval while I add a changelog
mahoneycm
reviewed
Dec 20, 2024
| @@ -54,6 +54,7 @@ If your project is currently using USWDS and you would like to see it included i | |||
| - [Digital Analytics Dashboard](https://analytics.usa.gov) | |||
| - [Digital Service Playbook — U.S. Digital Service](https://playbook.cio.gov) | |||
| - [Discovery Market Research Tool (GSA)](https://discovery.gsa.gov/) | |||
| - [Export Compliance Assistance Program (ECAP)](https://nnsa.nsis.anl.gov/ecap/) | |||
There was a problem hiding this comment.
Question: Should we order this to come after EPA to keep it alphabetical? Or lead with ECAP?
Not sure what the best way to keep these ordered when it comes to acronyms!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add ECAP to showcase.
Important
We need to update the changelog date before merge
Related issue
Closes #2704
Preview link
Showcase page
Testing and review