Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Add monthly call for November 2023 #2393

Merged
merged 10 commits into from
Dec 11, 2023
Merged

USWDS-Site: Add monthly call for November 2023 #2393

merged 10 commits into from
Dec 11, 2023

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Dec 8, 2023

Summary

Added the monthly call video and details for November 2023.

Related issue

Closes #2391

Preview link

Monthly calls page

Testing and review

  • Confirm that the information in the update is accurate
  • Confirm no spelling or grammatical errors
  • Confirm that the links all work as expected.

@amyleadem amyleadem marked this pull request as ready for review December 8, 2023 16:59
@amyleadem amyleadem requested a review from sarah-sch December 8, 2023 17:02
Copy link
Contributor

@sarah-sch sarah-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a change to the subtitle

_data/monthly-calls.yml Outdated Show resolved Hide resolved
_data/monthly-calls.yml Show resolved Hide resolved
Copy link
Contributor

@annepetersen annepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first three lines in the November entry (title, sub, first sentence) end with the same phrase. I wonder if we could alter "Conducting user research on how USWDS serves people with disabilities" somehow, maybe as "Conducting and sustaining our user research program"?

Also the title does not match the video's title, which is "Designing a repeatable research process with people with disabilities" and it probably should.

@@ -1,5 +1,21 @@
videos:
- title: Conducting user research with people with disabilities
- title: Designing a repeatable research process for people with disabilities
Copy link
Contributor

@sarah-sch sarah-sch Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amyleadem - Use title:

Designing a repeatable research process with people with disabilities

Copy link
Contributor Author

@amyleadem amyleadem Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the title to "Designing a repeatable research process with people with disabilities".

See the changes in this commit: 7586497

@@ -1,5 +1,21 @@
videos:
- title: Conducting user research with people with disabilities
- title: Designing a repeatable research process for people with disabilities
subtitle: Conducting user research on how USWDS serves people with disabilities
Copy link
Contributor

@sarah-sch sarah-sch Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amyleadem - New subtitle: Managing and sustaining our user research

@annepetersen, suggesting "managing," which strikes me as slightly more plain language/approachable than conducting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the subtitle to "Managing and sustaining our user research".

See the changes in this commit: 7586497

@sarah-sch
Copy link
Contributor

The first three lines in the November entry (title, sub, first sentence) end with the same phrase. I wonder if we could alter "Conducting user research on how USWDS serves people with disabilities" somehow, maybe as "Conducting and sustaining our user research program"?

Also the title does not match the video's title, which is "Designing a repeatable research process with people with disabilities" and it probably should.

Thank you, @annepetersen. I left some comments for Amy L. to change the title and subtitle and went with "Managing and sustaining our user research program."

@annepetersen
Copy link
Contributor

Looking at it again, we could even drop "program" from that sentence, don't you think, @sarah-sch?

@sarah-sch
Copy link
Contributor

Looking at it again, we could even drop "program" from that sentence, don't you think, @sarah-sch?

@annepetersen - yeah, that keeps things simpler. I've updated the instructions for Amy.

@amyleadem
Copy link
Contributor Author

@annepetersen @sarah-sch I made the requested updates. Please let me know if you need anything else.

- create fallback if the event page doesn't have the script yet
- add additional checks for data to prevent error
date: November 2023
id: EQ8Nb60xgXA?si=eHcGR5WjpOVeDc07
event_link: https://digital.gov/event/2023/11/16/uswds-monthly-call-november-2023/
missing_script: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new missing_script data field can be used when we have all items for the MC ready but the script hasn't been uploaded to digital.gov yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some checks to the template file to minimize risk in case we are missing any data fields.

@sarah-sch
Copy link
Contributor

@amyleadem - updates look good. @annepetersen, could you look when you get a chance? Thanks!

Copy link
Contributor

@annepetersen annepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@amyleadem amyleadem merged commit 25975ab into main Dec 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add November monthly call video to USWDS website
3 participants