-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Add monthly call for November 2023 #2393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a change to the subtitle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first three lines in the November entry (title, sub, first sentence) end with the same phrase. I wonder if we could alter "Conducting user research on how USWDS serves people with disabilities" somehow, maybe as "Conducting and sustaining our user research program"?
Also the title does not match the video's title, which is "Designing a repeatable research process with people with disabilities" and it probably should.
_data/monthly-calls.yml
Outdated
@@ -1,5 +1,21 @@ | |||
videos: | |||
- title: Conducting user research with people with disabilities | |||
- title: Designing a repeatable research process for people with disabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amyleadem - Use title:
Designing a repeatable research process with people with disabilities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the title to "Designing a repeatable research process with people with disabilities".
See the changes in this commit: 7586497
_data/monthly-calls.yml
Outdated
@@ -1,5 +1,21 @@ | |||
videos: | |||
- title: Conducting user research with people with disabilities | |||
- title: Designing a repeatable research process for people with disabilities | |||
subtitle: Conducting user research on how USWDS serves people with disabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amyleadem - New subtitle: Managing and sustaining our user research
@annepetersen, suggesting "managing," which strikes me as slightly more plain language/approachable than conducting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the subtitle to "Managing and sustaining our user research".
See the changes in this commit: 7586497
Thank you, @annepetersen. I left some comments for Amy L. to change the title and subtitle and went with "Managing and sustaining our user research program." |
Looking at it again, we could even drop "program" from that sentence, don't you think, @sarah-sch? |
@annepetersen - yeah, that keeps things simpler. I've updated the instructions for Amy. |
@annepetersen @sarah-sch I made the requested updates. Please let me know if you need anything else. |
- create fallback if the event page doesn't have the script yet - add additional checks for data to prevent error
date: November 2023 | ||
id: EQ8Nb60xgXA?si=eHcGR5WjpOVeDc07 | ||
event_link: https://digital.gov/event/2023/11/16/uswds-monthly-call-november-2023/ | ||
missing_script: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new missing_script
data field can be used when we have all items for the MC ready but the script hasn't been uploaded to digital.gov yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some checks to the template file to minimize risk in case we are missing any data fields.
@amyleadem - updates look good. @annepetersen, could you look when you get a chance? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
Summary
Added the monthly call video and details for November 2023.
Related issue
Closes #2391
Preview link
Monthly calls page
Testing and review