-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Use node lts 20 #2358
Conversation
- Downgrade prettier to prevent conflicts with old gulp-eslint library - Update available minor and patch versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New vulnerability
Running npm install
added a new high
rated vulnerability.
Luckily, npm audit fix
cleared it up and restored 0
vulnerabilities to match main
.
We should add that to this branch to limit vulnerabilities introduced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks for updating
HTMLProofer is failing because of new 18F URLs for guides. Opened issue in uswds/uswds#5683 because README content is being pulled on developer docs. |
|
Summary
Use latest LTS version of node. Update package dependencies and repo to use the latest LTS version of node. Prevents compatibility issues with cloud pages.
Related issue
Related to uswds/uswds#5010. Extension of #2304.
Preview link
Preview link [homepage]
Problem statement
To keep things up-to-date, secure, and functioning we need to update to latest node LTS version.
Solution
Testing and review
npm install
.Dependency updates
9.0.09.1.02.29.02.29.11.1246.01.258.01.1264.01.1266.0