Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site: Replace gulp-eslint #2357

Open
mejiaj opened this issue Nov 15, 2023 · 0 comments
Open

USWDS-Site: Replace gulp-eslint #2357

mejiaj opened this issue Nov 15, 2023 · 0 comments
Labels
Affects: Dependencies Relates to project dependencies Affects: Linting Relates to code linting Context: JavaScript Issue is in JavaScript Role: Dev Development/engineering skills needed

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Nov 15, 2023 •
edited
Loading

This plugin was last updated 4 years ago and is causing conflicts with using the latest version of ECMAScript, ESlint, and Prettier.

Causes linting issues and blocking updating prettier to v3.

Expected

  • Replace gulp-estlint with another method.
  • Update .estlintrc
    • Add eslint-config-prettier to extends.
    • Update .eslintrc to ensure we're using at least ES2020.
@mejiaj mejiaj added Affects: Linting Relates to code linting Affects: Dependencies Relates to project dependencies Role: Dev Development/engineering skills needed javascript Pull requests that update Javascript code labels Nov 15, 2023
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Nov 15, 2023
@mejiaj mejiaj mentioned this issue Nov 15, 2023
Merged
@brunerae brunerae added this to the 2024.01 January milestone Dec 14, 2023
@brunerae brunerae removed the Status: Triage We're triaging this issue and grooming if necessary label Dec 14, 2023
@brunerae brunerae added Context: JavaScript Issue is in JavaScript and removed javascript Pull requests that update Javascript code labels Mar 19, 2024
@brunerae brunerae removed this from the 2024.01 January milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: Dependencies Relates to project dependencies Affects: Linting Relates to code linting Context: JavaScript Issue is in JavaScript Role: Dev Development/engineering skills needed
Projects
USWDS Core Project Data
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mejiaj @brunerae