Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Compile - Dependencies: Install optional dependencies for sass-embedded #111

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

mahoneycm
Copy link
Contributor

Summary

Installed optional dependencies for sass-embedded to resolve initialization errors for some systems.

Related issue

Closes #110

Problem statement

Running npm init causes an error for some systems where sass-embedded cannot find the correct executable for their system.

Solution

Install all of sass-embedded's optional dependencies to support other developer machines.

Testing and review

  1. Checkout this branch
  2. Run npm ci
  3. Run npm run init
  4. Confirm there are no errors

Dependency updates

No direct dependency updates

@mahoneycm
Copy link
Contributor Author

Adding comment from @mdmower-csnw in the source issue (#110)

The updates to package-lock.json look complete (matches list of optionalDependencies for sass-embedded) and I verified I can compile successfully on both Windows 11 64bit and Debian 12 64bit.

Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Charlie! I can now install and run npm run init without errors on win11 x64.

@mejiaj mejiaj requested review from thisisdano and removed request for amyleadem July 16, 2024 13:37
@amyleadem amyleadem self-requested a review July 16, 2024 14:09
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix on this @mahoneycm. I was not able to replicate the original issue on my Mac, but I went ahead and performed the test here to confirm that the update in this branch didn't create any new issues for me. It didn't! I was able to run npm run init on this branch without error.

@amyleadem amyleadem requested a review from heymatthenry July 16, 2024 18:07
@heymatthenry heymatthenry merged commit c2db086 into develop Jul 17, 2024
1 check passed
@heymatthenry heymatthenry deleted the cm-sass-embed-optional-deps branch July 17, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Compile - Bug: Platform specific sass-embedded modules are missing from package lock
4 participants