Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builder): refactor types for action definitions #1608

Merged
merged 4 commits into from
Dec 30, 2024
Merged

fix(builder): refactor types for action definitions #1608

merged 4 commits into from
Dec 30, 2024

Conversation

mjlescano
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c919538

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mjlescano mjlescano requested a review from dbeal-eth December 30, 2024 00:18
dbeal-eth
dbeal-eth approved these changes Dec 30, 2024
View reviewed changes
packages/builder/src/actions.ts
label: string;

configInject: (ctx: ChainBuilderContextWithHelpers, config: any, packageState: PackageState) => any;
configInject: (ctx: ChainBuilderContextWithHelpers, config: Config, packageState: PackageState) => Config;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config argument should be a RawConfig type or so right?

Copy link
Member Author

@mjlescano mjlescano Dec 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this? cd57a1a I like it :)

FYI, by default is an any so we don't break the types in case someone is using the type when defining custom actions.

@mjlescano mjlescano enabled auto-merge December 30, 2024 00:49
@mjlescano mjlescano merged commit 2d5990e into dev Dec 30, 2024
8 of 9 checks passed
@mjlescano mjlescano deleted the fix-actions-types branch December 30, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeal-eth dbeal-eth dbeal-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjlescano @dbeal-eth