Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builder): template sanitization + sandboxing for untrusted code execution #1601

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from
Open

fix(builder): template sanitization + sandboxing for untrusted code execution #1601

wants to merge 22 commits into from
+1,552 −1,155

Conversation

saeta-eth
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4002289

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dbeal-eth
dbeal-eth requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! I particularly like the effort to add so much documentation throughout many parts of the codebase. Should improve the builder maintainability. amazing.

only a couple minor things to look at before this is mergable.

packages/builder/src/utils/template.ts Outdated Show resolved Hide resolved
packages/builder/src/utils/template.ts Outdated Show resolved Hide resolved
packages/builder/src/steps/invoke.ts Outdated Show resolved Hide resolved
packages/builder/src/utils/template.ts Outdated Show resolved Hide resolved
@mjlescano mjlescano force-pushed the fix/template-security-hole branch from 81ead96 to e360f92 Compare December 27, 2024 15:35
@mjlescano mjlescano marked this pull request as ready for review December 28, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjlescano mjlescano mjlescano left review comments

@dbeal-eth dbeal-eth dbeal-eth requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saeta-eth @mjlescano @dbeal-eth