Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): improve 2.20 speed significantly #1589

Merged
merged 5 commits into from
Dec 10, 2024
Merged

fix(builder): improve 2.20 speed significantly #1589

merged 5 commits into from
Dec 10, 2024

Conversation

dbeal-eth
Copy link
Contributor

works by removing unnecessary json srtingification and using arrays for stable comparison instead. uses generator function to minimize unnecessary computation.

this is critically important when you have synthetix scale deployments with hundreds of steps.

@dbeal-eth dbeal-eth requested a review from mjlescano December 10, 2024 12:49
@dbeal-eth dbeal-eth self-assigned this Dec 10, 2024
Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 21f4ce4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dbeal-eth dbeal-eth changed the base branch from dev to main December 10, 2024 12:50
@dbeal-eth dbeal-eth changed the title improve 2.20 speed significantly fix(builder): improve 2.20 speed significantly Dec 10, 2024
@dbeal-eth dbeal-eth enabled auto-merge (squash) December 10, 2024 14:07
@dbeal-eth dbeal-eth disabled auto-merge December 10, 2024 14:13
@dbeal-eth dbeal-eth enabled auto-merge (squash) December 10, 2024 14:19
@dbeal-eth dbeal-eth disabled auto-merge December 10, 2024 14:19
@dbeal-eth dbeal-eth merged commit 00d3ff1 into main Dec 10, 2024
7 of 9 checks passed
@dbeal-eth dbeal-eth deleted the speed branch December 10, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants