Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix sample code to avoid reading from undefined in didAuthError #3723

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ghengeveld
Copy link

Summary

This updates an example code snippet to prevent reading status from undefined.
According to the type definitions, response may be undefined. I can confirm because this happened in production.

Set of changes

  • Updated docs/advanced/authentication.md to add an optional chaining operator to handle undefined response.

Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: dfd53e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ghengeveld ghengeveld changed the title Response may be undefined Update example code to prevent reading from undefined in didAuthError Dec 19, 2024
@ghengeveld ghengeveld changed the title Update example code to prevent reading from undefined in didAuthError docs: Fix sample code to avoid reading from undefined in didAuthError Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant