-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat:(issue_10) Move providers into separate paths #11
base: main
Are you sure you want to change the base?
Conversation
@dearchap This is awesome! |
Overall, I am in favor of this direction 🎉 That being said, I haven't worked with nested modules enough to know the trade-offs. I think that given we're in a prerelease phase anyway, I would advocate for each module being in its own repository. This could also include addressing the awkwardness of namespace collisions so that instead of having to deal with package import aliases, the declared package names could be like |
What kind of collision awkwardness is expected? I find import like |
Here's a good example. https://github.com/knadh/koanf |
In keeping with koanf example above I have raised a PR in cli This allows map value sources to plugin easily without having to do custom lookups. Once that PR is approved the providers here neednt import the root urfave/cli-altsrc and then each provider can plugin to cli directly. How the provider retrieves its information and unmarshals can be left to its implementation |
Fixes #10