Parameterize the golangci-lint version for the provider repositories #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the Github action workflow call parameter "golangci-version" in provider-ci.yml - From time to time, we need to bump the golangci-lint version used with a specific official provider. In that case, we would like to be able to do so without a change in the uptest repo where the common CI definitions are, and to do so without bumping this dependency across all the provider repos. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
changed the title
1 task
ulucinar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
From time to time, we need to bump the golangci-lint version used with a specific official provider. In that case, we would like to be able to do so:
This PR parameterizes the golanci-lint version used in the provider build pipelines. It also bumps the default version used for that action to
v1.55.2, which is necessary for crossplane-contrib/provider-upjet-aws#1075.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
It's a little bit inconvenient to test these PRs as the providers consume these reusable workflows from the main branch of uptest due to security constraints on Github actions regarding the repo secrets. There are ways to test such PRs before merging them to the main branch but for relatively simple PRs like this one, we generally first merge them and test them from the main branch of
uptestin the official provider repositories. We may need to adopt a new strategy if these reusable workflows are used in other repositories as well.