Add the --enable-upjet-extensions
command-line option to process CRDs generated by upjet
#160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds the
--enable-upjet-extensions
common command-line option to thecrddiff
sub-commandsrevision
&self
to process CRDs generated by upjet. Currently, this enables processing of required properties defined by the x-kubernetes-validations CEL rules in upjet-generated CRDs. This enablescrddiff
to catch the breaking API changes introduced with upjet-generated CEL rules for the conditionally requiredspec.forProvider
fields. Upjet generates these conditions based on the management policies declared with thespec.managementPolicies
field.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Tested with the
crddiff revision
sub-command using the attached CRDs:crd_old.yaml
crd_old.yaml
Please note the:
section exclusive to the CRD in
crd_new.yaml
.