Skip to content

Commit

Permalink
Parametrize pr-comment-trigger(e2e) runs-on
Browse files Browse the repository at this point in the history
* Currently we have hardcoded self-hosted runner label that is specific
  to upbound
* It blocks the reusable workflow adoption outside of upbound

Signed-off-by: Yury Tsarev <[email protected]>
  • Loading branch information
ytsarev committed Oct 8, 2024
1 parent 932f24b commit d36315b
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/pr-comment-trigger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ on:
default: ''
required: false
type: string
runs-on:
default: e2-standard-8
required: false
type: string
secrets:
UPTEST_CLOUD_CREDENTIALS:
description: 'Uptest cloud credentials to be passed to the uptest target as environment variable'
Expand All @@ -42,7 +46,7 @@ on:

jobs:
debug:
runs-on: e2-standard-8
runs-on: ${{ inputs.runs-on }}
steps:
- name: Debug
run: |
Expand All @@ -54,7 +58,7 @@ jobs:
if: ${{ (github.event.comment.author_association == 'OWNER' || github.event.comment.author_association == 'MEMBER' || github.event.comment.author_association == 'COLLABORATOR' || github.event.comment.author_association == 'CONTRIBUTOR' ) &&
github.event.issue.pull_request &&
contains(github.event.comment.body, inputs.trigger-keyword ) }}
runs-on: e2-standard-8
runs-on: ${{ inputs.runs-on }}
outputs:
example_list: ${{ steps.get-example-list-name.outputs.example-list }}
example_hash: ${{ steps.get-example-list-name.outputs.example-hash }}
Expand Down Expand Up @@ -111,7 +115,7 @@ jobs:
if: ${{ (github.event.comment.author_association == 'OWNER' || github.event.comment.author_association == 'MEMBER' || github.event.comment.author_association == 'COLLABORATOR' || github.event.comment.author_association == 'CONTRIBUTOR' ) &&
github.event.issue.pull_request &&
contains(github.event.comment.body, inputs.trigger-keyword ) }}
runs-on: e2-standard-8
runs-on: ${{ inputs.runs-on }}
needs: get-example-list

steps:
Expand Down

0 comments on commit d36315b

Please sign in to comment.