Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(composition): update all examples, make input configurable #20

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Mar 17, 2024

Description of your changes

  • update all examples
  • make all fields configurable
  • update makefile

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

make render
Rendering examples/xr-cidrhost.yaml...
---
apiVersion: platform.upbound.io/v1alpha1
kind: XCIDR
metadata:
  name: cidr-host
status:
  atFunction:
    cidr:
      hostAddress: 10.0.0.111
  conditions:
  - lastTransitionTime: "2024-01-01T00:00:00Z"
    reason: Available
    status: "True"
    type: Ready
Rendering examples/xr-cidrnetmask.yaml...
---
apiVersion: platform.upbound.io/v1alpha1
kind: XCIDR
metadata:
  name: cidr-netmask
status:
  atFunction:
    cidr:
      netmask: 255.240.0.0
  conditions:
  - lastTransitionTime: "2024-01-01T00:00:00Z"
    reason: Available
    status: "True"
    type: Ready
Rendering examples/xr-cidrsubnet.yaml...
---
apiVersion: platform.upbound.io/v1alpha1
kind: XCIDR
metadata:
  name: cidr-subnet
status:
  atFunction:
    cidr:
      subnet-a: 10.0.0.0/28
  conditions:
  - lastTransitionTime: "2024-01-01T00:00:00Z"
    reason: Available
    status: "True"
    type: Ready
Rendering examples/xr-cidrsubnetloop.yaml...
---
apiVersion: platform.upbound.io/v1alpha1
kind: XCIDR
metadata:
  name: cidr-subnetloop
status:
  atFunction:
    cidr:
      subnets:
      - 10.0.0.48/32
      - 10.0.0.49/32
      - 10.0.0.50/32
  conditions:
  - lastTransitionTime: "2024-01-01T00:00:00Z"
    reason: Available
    status: "True"
    type: Ready
Rendering examples/xr-cidrsubnets.yaml...
---
apiVersion: platform.upbound.io/v1alpha1
kind: XCIDR
metadata:
  name: cidr-subnets
status:
  atFunction:
    cidr:
      subnets:
      - 10.0.0.0/28
      - 10.0.1.0/24
      - 10.0.4.0/22
  conditions:
  - lastTransitionTime: "2024-01-01T00:00:00Z"
    reason: Available
    status: "True"
    type: Ready

@haarchri haarchri force-pushed the feature/example-composition branch from 196f1ed to 1314027 Compare March 17, 2024 13:51
@haarchri haarchri requested a review from humoflife March 17, 2024 21:37
@humoflife
Copy link
Collaborator

/test-examples

@haarchri
Copy link
Member Author

@humoflife think no uptest implemented in this repo - it's a custom CI and makefile

Copy link
Collaborator

@humoflife humoflife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haarchri haarchri merged commit 230a9dd into main Mar 19, 2024
5 checks passed
@haarchri haarchri deleted the feature/example-composition branch March 19, 2024 10:31
mproffitt pushed a commit to mproffitt/function-cidr that referenced this pull request Jul 4, 2024
…und#20)

* feat(composition): update all examples, make input configurable

Signed-off-by: Christopher Haar <[email protected]>

* feat(composition): update all examples, make input configurable

Signed-off-by: Christopher Haar <[email protected]>

---------

Signed-off-by: Christopher Haar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants