Provide alternative XEKS composition with function-kcl #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury Tsarev <[email protected]>
* Use ObservedComposedResources map for direct data sharing instead of using standard to P&T bi-directional patching Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
* Default target enables usage of krm.kcl.dev/ready annotation Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Add dependencies Add SKIP_DELETE Signed-off-by: Yury Tsarev <[email protected]>
* Upgrade to latest v0.6.0 function-kcl that enables composition resource name override, crossplane-contrib/function-kcl#81 * It enables to keep same metadata.name for different resource kinds, providerConfigs of helm and kubernetes in this case * The metada.name = id is important convention that is used by other Configurations that integrate with configuration-aws-eks in the higher level platform-ref-aws Signed-off-by: Yury Tsarev <[email protected]>
|
With https://github.com/crossplane-contrib/function-kcl/releases/tag/v0.6.0 and b4f9a8b , now we can keep important ProviderConfig naming convention. |
Signed-off-by: Yury Tsarev <[email protected]>
|
/test-examples |
|
The uptest that covers both P&T and KCL implementations is green above ^. |
* Add missing policy to NodeGroup * Reference composed resources through `metada.name` instead of repetitive potentially error-prone convention Signed-off-by: Yury Tsarev <[email protected]>
* Align resource ordering creation with explicit conditionals * Figure out how to properly do multiline YAML string with KCL(indentation is important) Signed-off-by: Yury Tsarev <[email protected]>
|
/test-examples |
haarchri
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
"kcl" returned a fatal result: failed to run kcl function pipelines: Permission denied (os error 13)withv0.5.2release crossplane-contrib/function-kcl#71 and Ability to decouplemetadata.namefromcrossplane.io/composition-resource-nameandcrossplane.io/external-nameannotations crossplane-contrib/function-kcl#77 - (upd: both already fixed!)Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested