Skip to content

make fields of log struct public #200

make fields of log struct public

make fields of log struct public #200

Triggered via pull request January 16, 2024 21:26
Status Success
Total duration 3m 6s
Artifacts

clippy.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

65 warnings
empty `loop {}` wastes CPU cycles: boards/sensor/src/main.rs#L166
warning: empty `loop {}` wastes CPU cycles --> boards/sensor/src/main.rs:166:9 | 166 | loop {} | ^^^^^^^ | = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop = note: `#[warn(clippy::empty_loop)]` on by default
using `clone` on type `[u8; 1024]` which implements the `Copy` trait: boards/sensor/src/sbg_manager.rs#L133
warning: using `clone` on type `[u8; 1024]` which implements the `Copy` trait --> boards/sensor/src/sbg_manager.rs:133:33 | 133 | let buf_clone = buf.clone(); | ^^^^^^^^^^^ help: try dereferencing it: `*buf` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
this function has too many arguments (8/7): boards/sensor/src/communication.rs#L64
warning: this function has too many arguments (8/7) --> boards/sensor/src/communication.rs:64:5 | 64 | / pub fn new<S>( 65 | | can_rx: Pin<PA23, AlternateI>, 66 | | can_tx: Pin<PA22, AlternateI>, 67 | | pclk_can: Pclk<Can0, Gclk0Id>, ... | 72 | | loopback: bool, 73 | | ) -> (Self, S::Inc) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
very complex type used. Consider factoring parts into `type` definitions: boards/sensor/src/communication.rs#L54
warning: very complex type used. Consider factoring parts into `type` definitions --> boards/sensor/src/communication.rs:54:14 | 54 | pub can: Can< | ______________^ 55 | | 'static, 56 | | Can0, 57 | | Dependencies<Can0, Gclk0Id, Pin<PA23, Alternate<I>>, Pin<PA22, Alternate<I>>, CAN0>, 58 | | Capacities, 59 | | >, | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
very complex type used. Consider factoring parts into `type` definitions: boards/communication/src/main.rs#L51
warning: very complex type used. Consider factoring parts into `type` definitions --> boards/communication/src/main.rs:51:21 | 51 | sd_manager: SdManager< | _____________________^ 52 | | Spi< 53 | | Config< 54 | | Pads< ... | 64 | | Pin<PB14, Output<PushPull>>, 65 | | >, | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
this expression creates a reference which is immediately dereferenced by the compiler: boards/communication/src/main.rs#L222
warning: this expression creates a reference which is immediately dereferenced by the compiler --> boards/communication/src/main.rs:222:42 | 222 | manager.write(&mut file, &msg_ser)?; | ^^^^^^^^ help: change this to: `msg_ser` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: boards/communication/src/main.rs#L219
warning: this expression creates a reference which is immediately dereferenced by the compiler --> boards/communication/src/main.rs:219:42 | 219 | manager.write(&mut file, &msg_ser)?; | ^^^^^^^^ help: change this to: `msg_ser` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
empty `loop {}` wastes CPU cycles: boards/communication/src/main.rs#L171
warning: empty `loop {}` wastes CPU cycles --> boards/communication/src/main.rs:171:9 | 171 | loop {} | ^^^^^^^ | = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop = note: `#[warn(clippy::empty_loop)]` on by default
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: boards/communication/src/data_manager.rs#L104
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> boards/communication/src/data_manager.rs:104:49 | 104 | messages::Data::Command(command) => match command.data { | _________________________________________________^ 105 | | messages::command::CommandData::RadioRateChange(command_data) => { 106 | | self.logging_rate = Some(command_data.rate); 107 | | } 108 | | _ => {} 109 | | }, | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 104 ~ messages::Data::Command(command) => if let messages::command::CommandData::RadioRateChange(command_data) = command.data { 105 + self.logging_rate = Some(command_data.rate); 106 ~ }, |
unneeded `return` statement: boards/communication/src/data_manager.rs#L44
warning: unneeded `return` statement --> boards/communication/src/data_manager.rs:44:9 | 44 | return RadioRate::Slow; | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 44 - return RadioRate::Slow; 44 + RadioRate::Slow |
unneeded `return` statement: boards/communication/src/communication.rs#L306
warning: unneeded `return` statement --> boards/communication/src/communication.rs:306:44 | 306 | info!("Radio unknown msg"); | ____________________________________________^ 307 | | return; | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 306 - info!("Radio unknown msg"); 307 - return; 306 + info!("Radio unknown msg"); |
this function has too many arguments (8/7): boards/communication/src/communication.rs#L73
warning: this function has too many arguments (8/7) --> boards/communication/src/communication.rs:73:5 | 73 | / pub fn new<S>( 74 | | can_rx: Pin<PA23, AlternateI>, 75 | | can_tx: Pin<PA22, AlternateI>, 76 | | pclk_can: Pclk<Can0, Gclk0Id>, ... | 81 | | loopback: bool, 82 | | ) -> (Self, S::Inc) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
very complex type used. Consider factoring parts into `type` definitions: boards/communication/src/communication.rs#L63
warning: very complex type used. Consider factoring parts into `type` definitions --> boards/communication/src/communication.rs:63:14 | 63 | pub can: Can< | ______________^ 64 | | 'static, 65 | | Can0, 66 | | Dependencies<Can0, Gclk0Id, Pin<PA23, Alternate<I>>, Pin<PA22, Alternate<I>>, CAN0>, 67 | | Capacities, 68 | | >, | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
field `radio_manager` is never read: boards/communication/src/main.rs#L66
warning: field `radio_manager` is never read --> boards/communication/src/main.rs:66:9 | 66 | radio_manager: RadioManager, | ^^^^^^^^^^^^^ ... 76 | fn init(cx: init::Context) -> (Shared, Local, init::Monotonics) { | ----- field in this struct
fields `xfer` and `buf_select` are never read: boards/communication/src/communication.rs#L288
warning: fields `xfer` and `buf_select` are never read --> boards/communication/src/communication.rs:288:5 | 287 | pub struct RadioManager { | ------------ fields in this struct 288 | xfer: Option<RadioTransfer>, | ^^^^ 289 | buf_select: bool, | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
you seem to be trying to use `match` for an equality check. Consider using `if`: libraries/sbg-rs/src/sbg.rs#L477
warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> libraries/sbg-rs/src/sbg.rs:477:5 | 477 | / match logType { 478 | | // silently handle errors 479 | | // _SbgDebugLogType_SBG_DEBUG_LOG_TYPE_ERROR => error!("SBG Error"), 480 | | _SbgDebugLogType_SBG_DEBUG_LOG_TYPE_WARNING => warn!("SBG Warning"), ... | 483 | | _ => (), 484 | | }; | |_____^ help: try: `if logType == _SbgDebugLogType_SBG_DEBUG_LOG_TYPE_WARNING { warn!("SBG Warning") }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default
unsafe function's docs miss `# Safety` section: libraries/sbg-rs/src/sbg.rs#L457
warning: unsafe function's docs miss `# Safety` section --> libraries/sbg-rs/src/sbg.rs:457:1 | 457 | / pub unsafe extern "C" fn sbgPlatformDebugLogMsg( 458 | | _pFileName: *const ::core::ffi::c_char, 459 | | _pFunctionName: *const ::core::ffi::c_char, 460 | | _line: u32, ... | 464 | | _pFormat: *const ::core::ffi::c_char, 465 | | ) { | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
unneeded `return` statement: libraries/sbg-rs/src/sbg.rs#L419
warning: unneeded `return` statement --> libraries/sbg-rs/src/sbg.rs:419:23 | 419 | Err(_) => return _SbgErrorCode_SBG_READ_ERROR, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 419 | Err(_) => _SbgErrorCode_SBG_READ_ERROR, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
unneeded `return` statement: libraries/sbg-rs/src/sbg.rs#L418
warning: unneeded `return` statement --> libraries/sbg-rs/src/sbg.rs:418:22 | 418 | Ok(_) => return _SbgErrorCode_SBG_NO_ERROR, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 418 | Ok(_) => _SbgErrorCode_SBG_NO_ERROR, | ~~~~~~~~~~~~~~~~~~~~~~~~~~
unsafe function's docs miss `# Safety` section: libraries/sbg-rs/src/sbg.rs#L404
warning: unsafe function's docs miss `# Safety` section --> libraries/sbg-rs/src/sbg.rs:404:5 | 404 | / pub unsafe extern "C" fn SbgFlushFunc( 405 | | pInterface: *mut _SbgInterface, 406 | | _flags: u32, 407 | | ) -> _SbgErrorCode { | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
unsafe function's docs miss `# Safety` section: libraries/sbg-rs/src/sbg.rs#L313
warning: unsafe function's docs miss `# Safety` section --> libraries/sbg-rs/src/sbg.rs:313:5 | 313 | / pub unsafe extern "C" fn SbgInterfaceWriteFunc( 314 | | pInterface: *mut _SbgInterface, 315 | | pBuffer: *const c_void, 316 | | bytesToWrite: usize, 317 | | ) -> _SbgErrorCode { | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
the loop variable `i` is only used to index `array`: libraries/sbg-rs/src/sbg.rs#L296
warning: the loop variable `i` is only used to index `array` --> libraries/sbg-rs/src/sbg.rs:296:18 | 296 | for i in 0..(bytesToRead) { | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator | 296 | for <item> in array.iter_mut().take((bytesToRead)) { | ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
unneeded `return` statement: libraries/sbg-rs/src/sbg.rs#L307
warning: unneeded `return` statement --> libraries/sbg-rs/src/sbg.rs:307:9 | 307 | return _SbgErrorCode_SBG_NO_ERROR; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 307 - return _SbgErrorCode_SBG_NO_ERROR; 307 + _SbgErrorCode_SBG_NO_ERROR |
unsafe function's docs miss `# Safety` section: libraries/sbg-rs/src/sbg.rs#L277
warning: unsafe function's docs miss `# Safety` section --> libraries/sbg-rs/src/sbg.rs:277:5 | 277 | / pub unsafe extern "C" fn SbgInterfaceReadFunc( 278 | | _pInterface: *mut _SbgInterface, 279 | | pBuffer: *mut c_void, 280 | | pBytesRead: *mut usize, 281 | | bytesToRead: usize, 282 | | ) -> _SbgErrorCode { | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default
empty `loop {}` wastes CPU cycles: boards/camera/src/main.rs#L109
warning: empty `loop {}` wastes CPU cycles --> boards/camera/src/main.rs:109:9 | 109 | loop {} | ^^^^^^^ | = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop = note: `#[warn(clippy::empty_loop)]` on by default
empty `loop {}` wastes CPU cycles: boards/recovery/src/main.rs#L124
warning: empty `loop {}` wastes CPU cycles --> boards/recovery/src/main.rs:124:9 | 124 | loop {} | ^^^^^^^ | = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop = note: `#[warn(clippy::empty_loop)]` on by default
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: boards/recovery/src/state_machine/mod.rs#L106
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> boards/recovery/src/state_machine/mod.rs:106:1 | 106 | impl Into<state::StateData> for RocketStates { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `#[warn(clippy::from_over_into)]` on by default help: replace the `Into` implementation with `From<state_machine::RocketStates>` | 106 ~ impl From<RocketStates> for state::StateData { 107 ~ fn from(val: RocketStates) -> Self { 108 ~ match val { |
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: boards/camera/src/state_machine/mod.rs#L106
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> boards/camera/src/state_machine/mod.rs:106:1 | 106 | impl Into<state::StateData> for RocketStates { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `#[warn(clippy::from_over_into)]` on by default help: replace the `Into` implementation with `From<state_machine::RocketStates>` | 106 ~ impl From<RocketStates> for state::StateData { 107 ~ fn from(val: RocketStates) -> Self { 108 ~ match val { |
empty `loop {}` wastes CPU cycles: boards/power/src/main.rs#L114
warning: empty `loop {}` wastes CPU cycles --> boards/power/src/main.rs:114:9 | 114 | loop {} | ^^^^^^^ | = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop = note: `#[warn(clippy::empty_loop)]` on by default
this function has too many arguments (8/7): boards/power/src/communication.rs#L60
warning: this function has too many arguments (8/7) --> boards/power/src/communication.rs:60:5 | 60 | / pub fn new<S>( 61 | | can_rx: Pin<PA23, AlternateI>, 62 | | can_tx: Pin<PA22, AlternateI>, 63 | | pclk_can: Pclk<Can0, Gclk0Id>, ... | 68 | | loopback: bool, 69 | | ) -> (Self, S::Inc) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
very complex type used. Consider factoring parts into `type` definitions: boards/power/src/communication.rs#L50
warning: very complex type used. Consider factoring parts into `type` definitions --> boards/power/src/communication.rs:50:14 | 50 | pub can: Can< | ______________^ 51 | | 'static, 52 | | Can0, 53 | | Dependencies<Can0, Gclk0Id, Pin<PA23, Alternate<I>>, Pin<PA22, Alternate<I>>, CAN0>, 54 | | Capacities, 55 | | >, | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
fields `data_manager` and `can0` are never read: boards/power/src/main.rs#L29
warning: fields `data_manager` and `can0` are never read --> boards/power/src/main.rs:29:9 | 29 | data_manager: DataManager, | ^^^^^^^^^^^^ 30 | can0: CanDevice0, | ^^^^ ... 46 | fn init(cx: init::Context) -> (Shared, Local, init::Monotonics) { | ------ fields in this struct
method `handle_data` is never used: boards/power/src/data_manager.rs#L38
warning: method `handle_data` is never used --> boards/power/src/data_manager.rs:38:12 | 12 | impl DataManager { | ---------------- method in this implementation ... 38 | pub fn handle_data(&mut self, _data: Message) { | ^^^^^^^^^^^
field `line_interrupts` is never read: boards/power/src/communication.rs#L56
warning: field `line_interrupts` is never read --> boards/power/src/communication.rs:56:5 | 49 | pub struct CanDevice0 { | ---------- field in this struct ... 56 | line_interrupts: OwnedInterruptSet<Can0, EnabledLine0>, | ^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: boards/camera/src/data_manager.rs#L108
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> boards/camera/src/data_manager.rs:108:47 | 108 | messages::Data::Sensor(sensor) => match sensor.data { | _______________________________________________^ 109 | | messages::sensor::SensorData::Air(air_data) => { 110 | | self.air = Some(air_data); 111 | | } 112 | | _ => { 113 | | } 114 | | }, | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 108 ~ messages::Data::Sensor(sensor) => if let messages::sensor::SensorData::Air(air_data) = sensor.data { 109 + self.air = Some(air_data); 110 ~ }, |
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: boards/camera/src/data_manager.rs#L107
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> boards/camera/src/data_manager.rs:107:9 | 107 | / match data.data { 108 | | messages::Data::Sensor(sensor) => match sensor.data { 109 | | messages::sensor::SensorData::Air(air_data) => { 110 | | self.air = Some(air_data); ... | 116 | | } 117 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 107 ~ if let messages::Data::Sensor(sensor) = data.data { match sensor.data { 108 + messages::sensor::SensorData::Air(air_data) => { 109 + self.air = Some(air_data); 110 + } 111 + _ => { 112 + } 113 + } } |
this function has too many arguments (8/7): boards/recovery/src/communication.rs#L62
warning: this function has too many arguments (8/7) --> boards/recovery/src/communication.rs:62:5 | 62 | / pub fn new<S>( 63 | | can_rx: Pin<PA23, AlternateI>, 64 | | can_tx: Pin<PA22, AlternateI>, 65 | | pclk_can: Pclk<Can0, Gclk0Id>, ... | 70 | | loopback: bool, 71 | | ) -> (Self, S::Inc) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
very complex type used. Consider factoring parts into `type` definitions: boards/recovery/src/communication.rs#L52
warning: very complex type used. Consider factoring parts into `type` definitions --> boards/recovery/src/communication.rs:52:14 | 52 | pub can: Can< | ______________^ 53 | | 'static, 54 | | Can0, 55 | | Dependencies<Can0, Gclk0Id, Pin<PA23, Alternate<I>>, Pin<PA22, Alternate<I>>, CAN0>, 56 | | Capacities, 57 | | >, | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
variants `DeployDrogue` and `DeployMain` are never constructed: boards/recovery/src/state_machine/mod.rs#L72
warning: variants `DeployDrogue` and `DeployMain` are never constructed --> boards/recovery/src/state_machine/mod.rs:72:5 | 71 | pub enum RocketEvents { | ------------ variants in this enum 72 | DeployDrogue, | ^^^^^^^^^^^^ 73 | DeployMain, | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
this function has too many arguments (8/7): boards/camera/src/communication.rs#L76
warning: this function has too many arguments (8/7) --> boards/camera/src/communication.rs:76:5 | 76 | / pub fn new<S>( 77 | | can_rx: Pin<PA23, AlternateI>, 78 | | can_tx: Pin<PA22, AlternateI>, 79 | | pclk_can: Pclk<Can0, Gclk0Id>, ... | 84 | | loopback: bool, 85 | | ) -> (Self, S::Inc) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
very complex type used. Consider factoring parts into `type` definitions: boards/camera/src/communication.rs#L66
warning: very complex type used. Consider factoring parts into `type` definitions --> boards/camera/src/communication.rs:66:14 | 66 | pub can: Can< | ______________^ 67 | | 'static, 68 | | Can0, 69 | | Dependencies<Can0, Gclk0Id, Pin<PA23, Alternate<I>>, Pin<PA22, Alternate<I>>, CAN0>, 70 | | Capacities, 71 | | >, | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
variants `DeployDrogue` and `DeployMain` are never constructed: boards/camera/src/state_machine/mod.rs#L72
warning: variants `DeployDrogue` and `DeployMain` are never constructed --> boards/camera/src/state_machine/mod.rs:72:5 | 71 | pub enum RocketEvents { | ------------ variants in this enum 72 | DeployDrogue, | ^^^^^^^^^^^^ 73 | DeployMain, | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
redundant field names in struct initialization: libraries/sbg-rs/src/sbg.rs#L141
warning: redundant field names in struct initialization --> libraries/sbg-rs/src/sbg.rs:141:13 | 141 | handle: handle, | ^^^^^^^^^^^^^^ help: replace it with: `handle` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `#[warn(clippy::redundant_field_names)]` on by default
unused import: `self::_SbgEComOutputMonitoringPoint as SbgEComOutputMonitoringPoint`: libraries/sbg-rs/src/bindings.rs#L13476
warning: unused import: `self::_SbgEComOutputMonitoringPoint as SbgEComOutputMonitoringPoint` --> libraries/sbg-rs/src/bindings.rs:13476:9 | 13476 | pub use self::_SbgEComOutputMonitoringPoint as SbgEComOutputMonitoringPoint; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComClockUtcStatus as SbgEComClockUtcStatus`: libraries/sbg-rs/src/bindings.rs#L10537
warning: unused import: `self::_SbgEComClockUtcStatus as SbgEComClockUtcStatus` --> libraries/sbg-rs/src/bindings.rs:10537:9 | 10537 | pub use self::_SbgEComClockUtcStatus as SbgEComClockUtcStatus; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComClockStatus as SbgEComClockStatus`: libraries/sbg-rs/src/bindings.rs#L10527
warning: unused import: `self::_SbgEComClockStatus as SbgEComClockStatus` --> libraries/sbg-rs/src/bindings.rs:10527:9 | 10527 | pub use self::_SbgEComClockStatus as SbgEComClockStatus; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComCanBusStatus as SbgEComCanBusStatus`: libraries/sbg-rs/src/bindings.rs#L10251
warning: unused import: `self::_SbgEComCanBusStatus as SbgEComCanBusStatus` --> libraries/sbg-rs/src/bindings.rs:10251:9 | 10251 | pub use self::_SbgEComCanBusStatus as SbgEComCanBusStatus; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComGpsHdtStatus as SbgEComGpsHdtStatus`: libraries/sbg-rs/src/bindings.rs#L8535
warning: unused import: `self::_SbgEComGpsHdtStatus as SbgEComGpsHdtStatus` --> libraries/sbg-rs/src/bindings.rs:8535:9 | 8535 | pub use self::_SbgEComGpsHdtStatus as SbgEComGpsHdtStatus; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComGpsPosType as SbgEComGpsPosType`: libraries/sbg-rs/src/bindings.rs#L8523
warning: unused import: `self::_SbgEComGpsPosType as SbgEComGpsPosType` --> libraries/sbg-rs/src/bindings.rs:8523:9 | 8523 | pub use self::_SbgEComGpsPosType as SbgEComGpsPosType; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComGpsPosStatus as SbgEComGpsPosStatus`: libraries/sbg-rs/src/bindings.rs#L8497
warning: unused import: `self::_SbgEComGpsPosStatus as SbgEComGpsPosStatus` --> libraries/sbg-rs/src/bindings.rs:8497:9 | 8497 | pub use self::_SbgEComGpsPosStatus as SbgEComGpsPosStatus; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComGpsVelType as SbgEComGpsVelType`: libraries/sbg-rs/src/bindings.rs#L8485
warning: unused import: `self::_SbgEComGpsVelType as SbgEComGpsVelType` --> libraries/sbg-rs/src/bindings.rs:8485:9 | 8485 | pub use self::_SbgEComGpsVelType as SbgEComGpsVelType; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComGpsVelStatus as SbgEComGpsVelStatus`: libraries/sbg-rs/src/bindings.rs#L8473
warning: unused import: `self::_SbgEComGpsVelStatus as SbgEComGpsVelStatus` --> libraries/sbg-rs/src/bindings.rs:8473:9 | 8473 | pub use self::_SbgEComGpsVelStatus as SbgEComGpsVelStatus; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComSolutionMode as SbgEComSolutionMode`: libraries/sbg-rs/src/bindings.rs#L8004
warning: unused import: `self::_SbgEComSolutionMode as SbgEComSolutionMode` --> libraries/sbg-rs/src/bindings.rs:8004:9 | 8004 | pub use self::_SbgEComSolutionMode as SbgEComSolutionMode; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComCmd as SbgEComCmd`: libraries/sbg-rs/src/bindings.rs#L7306
warning: unused import: `self::_SbgEComCmd as SbgEComCmd` --> libraries/sbg-rs/src/bindings.rs:7306:9 | 7306 | pub use self::_SbgEComCmd as SbgEComCmd; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComIdThirdParty as SbgEComIdThirdParty`: libraries/sbg-rs/src/bindings.rs#L7212
warning: unused import: `self::_SbgEComIdThirdParty as SbgEComIdThirdParty` --> libraries/sbg-rs/src/bindings.rs:7212:9 | 7212 | pub use self::_SbgEComIdThirdParty as SbgEComIdThirdParty; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComIdNmea1Log as SbgEComIdNmea1Log`: libraries/sbg-rs/src/bindings.rs#L7184
warning: unused import: `self::_SbgEComIdNmea1Log as SbgEComIdNmea1Log` --> libraries/sbg-rs/src/bindings.rs:7184:9 | 7184 | pub use self::_SbgEComIdNmea1Log as SbgEComIdNmea1Log; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComNmeaLog as SbgEComNmeaLog`: libraries/sbg-rs/src/bindings.rs#L7152
warning: unused import: `self::_SbgEComNmeaLog as SbgEComNmeaLog` --> libraries/sbg-rs/src/bindings.rs:7152:9 | 7152 | pub use self::_SbgEComNmeaLog as SbgEComNmeaLog; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComLog1MsgId as SbgEComLog1`: libraries/sbg-rs/src/bindings.rs#L7126
warning: unused import: `self::_SbgEComLog1MsgId as SbgEComLog1` --> libraries/sbg-rs/src/bindings.rs:7126:9 | 7126 | pub use self::_SbgEComLog1MsgId as SbgEComLog1; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgEComLog as SbgEComLog`: libraries/sbg-rs/src/bindings.rs#L7118
warning: unused import: `self::_SbgEComLog as SbgEComLog` --> libraries/sbg-rs/src/bindings.rs:7118:9 | 7118 | pub use self::_SbgEComLog as SbgEComLog; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `self::_SbgSBSeekOrigin as SbgSBSeekOrigin`: libraries/sbg-rs/src/bindings.rs#L6822
warning: unused import: `self::_SbgSBSeekOrigin as SbgSBSeekOrigin` --> libraries/sbg-rs/src/bindings.rs:6822:9 | 6822 | pub use self::_SbgSBSeekOrigin as SbgSBSeekOrigin; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/