chore: ITemplatedParentProvider removal #18443

Xiaoy312 · 2024-10-10T20:27:33Z

GitHub Issue (If applicable): n/a

PR Type

What kind of change does this PR introduce?

Refactoring (no functional changes, no api changes)

What is the new behavior?

follow-up of #17645
removing ITemplatedParentProvider and relevant codegen in DOGenerator, replaced with direct implementations in DOStore.
add a few more tests against regressions found in the tp rework.
ninja-fix: native Frame not being initialized.

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Other information

With changes from this PR and #17645, there are a few notable changes to the templated-parent system:

DO::TemplatedParent dependency property, ::OnTemplatedParentChanged(e), and DOStore.SetTemplatedParent(FrameworkElement) are fully deprecated. They are no longer called by the Uno framework, and should not be used anymore. They are, however, still temporarily kept in v5.5.0 to avoid binary changes until next major version.

Access to the templated-parent, can now be made through the following code:

// within uno.ui assembly
DependencyObject DependencyObjectExtensions.GetTemplatedParent(this DependencyObject @do);
void DependencyObjectExtensions.SetTemplatedParent(this DependencyObject @do, DependencyObject tp);
DependencyObject FrameworkElement.GetTemplatedParent();
void FrameworkElement.GetTemplatedParent(DependencyObject tp);
// outside uno
(do_or_fe as IDependencyObjectStoreProvider)?.Store.GetTemplatedParent2(); // note: the -2 suffix here is to distinguished between the old deprecated method.
//(do_or_fe as IDependencyObjectStoreProvider)?.Store.SetTemplatedParent2(null); // you shouldnt need this

override to OnTemplatedParentChanged, should be replaced by OnLoaded()(within uno.ui assembly) or FE.Loaded += ...(outside uno).

unodevops · 2024-10-10T22:10:42Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18443/index.html

unodevops · 2024-10-10T22:57:46Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18443/index.html

....UI.SourceGenerators.Tests/DependencyObjectGeneratorTests/Given_DependencyObjectGenerator.cs

src/SourceGenerators/Uno.UI.SourceGenerators/DependencyObject/DependencyObjectGenerator.cs

Youssef1313

This needs to be tested at least on Gallery just to make sure it's not breaking the legacy impl. But changes LGTM as long as it will be backported to 5.5 soon.

jeromelaban · 2024-10-11T20:16:10Z

@Mergifyio backport release/stable/5.5

mergify · 2024-10-11T20:16:22Z

backport release/stable/5.5

✅ Backports have been created

#18457 chore: ITemplatedParentProvider removal (backport #18443) has been created for branch release/stable/5.5

unodevops · 2024-10-11T20:34:19Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18443/index.html

unodevops · 2024-10-11T23:19:21Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18443/index.html

unodevops · 2024-10-11T23:20:34Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18443/index.html

unodevops · 2024-10-11T23:44:30Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18443/index.html

unodevops · 2024-10-11T23:47:41Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18443/index.html

unodevops · 2024-10-12T16:27:39Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18443/index.html

unodevops · 2024-10-12T16:38:08Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18443/index.html

unodevops · 2024-10-13T02:16:12Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18443/index.html

unodevops · 2024-10-13T02:19:50Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18443/index.html

nventive-devops · 2024-10-13T03:57:17Z

The build 143346 found UI Test snapshots differences: android-28-net8: 18, android-28-net8-Snap: 46, ios: 10, ios-Snap: 49, skia-gtk-screenshots: 69, skia-linux-screenshots: 59, skia-windows-screenshots: 59, wasm: 496, wasm-automated-net9.0-UWP-Default-automated: 26, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 18 changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨
- Button_OverlappedButtons_UITests_Shared_Windows_UI_Xaml_Controls_Button_Overlapped_Buttons
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- FlyoutTest_Target_Uno_UI_Samples_Content_UITests_Flyout_Flyout_Target
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- WebView_NavigateToAnchor_Initial
- WebView_NavigateToAnchor_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
android-28-net8-Snap: 46 changed over 1066
🚨🚨 Comparison Details (first 20) 🚨🚨
- MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
- Brushes_ImageBrushWithLateSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithLateSource
- Brushes_ImageBrushWithCompositeTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithCompositeTransform
- NavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPage
- TextBox_TextBoxPadding_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBoxPadding
- Transform_Polygon_With_RotateTransform_SamplesApp_Wasm_Windows_UI_Xaml_Media_Transform_Polygon_With_RotateTransform
- ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- Transform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics
- Animations_UITests_Windows_UI_Xaml_Media_Animation_FadeInOutThemeAnimationPage_UITests_Windows_UI_Xaml_Media_Animation_FadeInOutThemeAnimationPage
- Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
- TextBox_UITests_Shared_Windows_UI_Xaml_Controls_PasswordBoxTests_PasswordBoxPage_UITests_Shared_Windows_UI_Xaml_Controls_PasswordBoxTests_PasswordBoxPage
- TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout
- TextBox_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_Selection_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_Selection
- Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
- Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
- Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
- MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage
- Automation_AutomationProperties_AutomationId_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_AutomationId
- Transform_Rectangle_With_RotateTransform_SamplesApp_Wasm_Windows_UI_Xaml_Media_Transform_Rectangle_With_RotateTransform
ios: 10 changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨
- Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ListView_ListViewWithHeader_InitializesTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
ios-Snap: 49 changed over 1057
🚨🚨 Comparison Details (first 20) 🚨🚨
- NavigationView_MUXControlsTestApp_PaneLayoutTestPage_MUXControlsTestApp_PaneLayoutTestPage
- TextBlock_TextBlock_FixedWidth_With_DataBound_Run_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FixedWidth_With_DataBound_Run
- Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
- Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
- NavigationView_MUXControlsTestApp_NavigationViewMenuItemStretchPage_MUXControlsTestApp_NavigationViewMenuItemStretchPage
- Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform
- NavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage
- Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
- ContentControl_ContentControl_UnsetContent_GenericApp_Views_Content_UITests_ContentControlTestsControl_ContentControl_UnsetContent
- Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_ImageAlignment2541_UITests_Windows_UI_Xaml_Controls_ImageTests_ImageAlignment2541
- TextBlock_TextBoxSizeChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBoxSizeChanging
- Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
- Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable
- Shapes_UITests_Windows_UI_Xaml_Shapes_Ellipse_Positioning_UITests_Windows_UI_Xaml_Shapes_Ellipse_Positioning
- Brushes_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
- ListView_HorizontalListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
skia-gtk-screenshots: 69 changed over 2220
🚨🚨 Comparison Details (first 20) 🚨🚨
- CalendarView_Theming.png-dark
- CalendarView_Theming.png
- ContentPresenter_NativeEmbedding.png
- ListViewHeaderUpdate.png-dark
- ListViewHeaderUpdate.png
- Gamepad_Enumeration.png-dark
- WinUIProgressBarSimple.png-dark
- WinUIProgressBarSimple.png
- ImageBrushInList.png-dark
- ImageBrushInList.png
- ClipboardTests.png-dark
- ClipboardTests.png
- Gamepad_Enumeration.png
- ImageBrushStretch2.png
- WinUIExpanderPage.png-dark
- WinUIExpanderPage.png
- ButtonClippingTestsControl.png-dark
- ButtonClippingTestsControl.png
- Buttons.png-dark
- Buttons.png
skia-linux-screenshots: 59 changed over 2220
🚨🚨 Comparison Details (first 20) 🚨🚨
- CalendarView_Theming.png-dark
- ButtonClippingTestsControl.png-dark
- ContentPresenter_NativeEmbedding.png-dark
- ContentPresenter_NativeEmbedding.png
- Ellipse.png-dark
- Ellipse.png
- ClipboardTests.png-dark
- ClipboardTests.png
- Examples.png
- ExpanderColorValidationPage.png-dark
- ExpanderColorValidationPage.png
- ImageIconPage.png-dark
- ImageIconPage.png
- DisplayInformation.png-dark
- DisplayInformation.png
- ImageBrushStretch.png-dark
- ImageBrushStretch.png
- Buttons.png-dark
- CalendarView_Theming.png
- DropDownButtonPage.png-dark
skia-windows-screenshots: 59 changed over 2220
🚨🚨 Comparison Details (first 20) 🚨🚨
- CalendarView_Theming.png-dark
- Focus_FocusVisual_Properties.png-dark
- ClipboardTests.png-dark
- ClipboardTests.png
- ButtonClippingTestsControl.png-dark
- ButtonClippingTestsControl.png
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
- ImageBrush_UniformToFill.png-dark
- ImageBrush_UniformToFill.png
- ImageIconPage.png-dark
- ImageIconPage.png
- ImageBrush_SameWithDelay.png-dark
- ImageBrush_SameWithDelay.png
- Buttons.png
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- Examples.png
- Gamepad_CurrentReading.png-dark
- DisplayInformation.png-dark
wasm: 496 changed over 1044
🚨🚨 Comparison Details (first 20) 🚨🚨
- GenericApp.Views.Content.UITests.ImageBrushTestControl.ImageBrush_UniformToFill
- MUXControlsTestApp.InfoBarPage
- MUXControlsTestApp.PipsPagerPage
- MUXControlsTestApp.SwipeControlPage
- SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_NavigateToUri
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Popover
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ScrollViewer
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGroupedEmpty
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewVariableHeightComplexTemplate
- SamplesApp.Windows_UI_Xaml_Media.Geometry.LineSegmentPage
- SamplesApp.Windows_UI_Xaml_Shapes.EllipsePage
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchUniformAutoSize
- UITests.Microsoft_UI_Xaml_Controls.NavigationViewTests.NavigationViewBasicPage
- UITests.Microsoft_UI_Xaml_Controls.NumberBoxTests.NumberBox_Description
- UITests.Microsoft_UI_Xaml_Controls.NumberBoxTests.NumberBox_ExpressionTest
- UITests.Shared.Microsoft_UI_Xaml_Controls.TwoPaneViewTests.TwoPaneViewPage
- UITests.Shared.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_NavigateToString2
- UITests.Shared.Resources.StaticResource.StaticResource_Simple
- UITests.Shared.Windows_UI_Xaml.xBindTests.xBind_Field
- UITests.Shared.Windows_UI_Xaml.xBindTests.xBind_Functions
wasm-automated-net9.0-UWP-Default-automated: 26 changed over 1946
🚨🚨 Comparison Details (first 20) 🚨🚨
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
- Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- Default_StrokeThickness_MyRect
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Default_StrokeThickness_MyPath
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
- Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

…5.5/pr-18443 chore: ITemplatedParentProvider removal (backport #18443)

Xiaoy312 requested review from jeromelaban and Youssef1313 October 10, 2024 20:27

Xiaoy312 force-pushed the dev/xygu/20241009/templated-parent-rework-v3_1 branch from b85c2d0 to 32f326d Compare October 10, 2024 21:14

Youssef1313 reviewed Oct 11, 2024

View reviewed changes

....UI.SourceGenerators.Tests/DependencyObjectGeneratorTests/Given_DependencyObjectGenerator.cs Show resolved Hide resolved

Youssef1313 reviewed Oct 11, 2024

View reviewed changes

src/SourceGenerators/Uno.UI.SourceGenerators/DependencyObject/DependencyObjectGenerator.cs Show resolved Hide resolved

Youssef1313 approved these changes Oct 11, 2024

View reviewed changes

Xiaoy312 force-pushed the dev/xygu/20241009/templated-parent-rework-v3_1 branch from 32f326d to 684bf20 Compare October 11, 2024 19:37

chore: add tests against tp regressions

9b70b99

Xiaoy312 force-pushed the dev/xygu/20241009/templated-parent-rework-v3_1 branch from 684bf20 to ba8410f Compare October 11, 2024 22:46

github-actions bot removed the platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform label Oct 11, 2024

chore: ITemplatedParentProvider removal

147c879

Xiaoy312 force-pushed the dev/xygu/20241009/templated-parent-rework-v3_1 branch from ba8410f to 147c879 Compare October 11, 2024 23:15

Xiaoy312 requested a review from Youssef1313 October 11, 2024 23:18

Xiaoy312 added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Oct 11, 2024

jeromelaban approved these changes Oct 12, 2024

View reviewed changes

chore: Adjust for GetTP new location

08691ec

jeromelaban enabled auto-merge October 12, 2024 15:53

chore: Adjust maps dependency

f3c3de2

jeromelaban merged commit 4babcb4 into master Oct 13, 2024
106 checks passed

jeromelaban deleted the dev/xygu/20241009/templated-parent-rework-v3_1 branch October 13, 2024 04:06

mergify bot mentioned this pull request Oct 13, 2024

chore: ITemplatedParentProvider removal (backport #18443) #18457

Merged

6 tasks

jeromelaban added a commit that referenced this pull request Oct 13, 2024

Merge pull request #18457 from unoplatform/mergify/bp/release/stable/…

e0a3158

…5.5/pr-18443 chore: ITemplatedParentProvider removal (backport #18443)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: ITemplatedParentProvider removal #18443

chore: ITemplatedParentProvider removal #18443

Xiaoy312 commented Oct 10, 2024 •

edited

Loading

unodevops commented Oct 10, 2024

unodevops commented Oct 10, 2024

Youssef1313 left a comment

jeromelaban commented Oct 11, 2024

mergify bot commented Oct 11, 2024 •

edited

Loading

unodevops commented Oct 11, 2024

unodevops commented Oct 11, 2024

unodevops commented Oct 11, 2024

unodevops commented Oct 11, 2024

unodevops commented Oct 11, 2024

unodevops commented Oct 12, 2024

unodevops commented Oct 12, 2024

unodevops commented Oct 13, 2024

unodevops commented Oct 13, 2024

nventive-devops commented Oct 13, 2024

chore: ITemplatedParentProvider removal #18443

chore: ITemplatedParentProvider removal #18443

Conversation

Xiaoy312 commented Oct 10, 2024 • edited Loading

PR Type

What is the new behavior?

PR Checklist

Other information

unodevops commented Oct 10, 2024

unodevops commented Oct 10, 2024

Youssef1313 left a comment

Choose a reason for hiding this comment

jeromelaban commented Oct 11, 2024

mergify bot commented Oct 11, 2024 • edited Loading

✅ Backports have been created

unodevops commented Oct 11, 2024

unodevops commented Oct 11, 2024

unodevops commented Oct 11, 2024

unodevops commented Oct 11, 2024

unodevops commented Oct 11, 2024

unodevops commented Oct 12, 2024

unodevops commented Oct 12, 2024

unodevops commented Oct 13, 2024

unodevops commented Oct 13, 2024

nventive-devops commented Oct 13, 2024

Xiaoy312 commented Oct 10, 2024 •

edited

Loading

mergify bot commented Oct 11, 2024 •

edited

Loading