Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(governance): parse DAO domain id correctly in cross-chain health check #15283

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Dec 20, 2024

Description

A fix for a bug introduced in previous change that was breaking our cross chain status check

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@clemsos clemsos requested a review from julien51 December 20, 2024 14:59
@cla-bot cla-bot bot added the cla-signed label Dec 20, 2024
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unlock-static-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 3:14pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unlock-storybook ⬜️ Ignored (Inspect) Dec 20, 2024 3:14pm

@clemsos clemsos merged commit 3b4668f into master Dec 21, 2024
16 checks passed
@clemsos clemsos deleted the fix-gov-check branch December 21, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants