Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(locksmith): Event deployment worker #15259

Merged
merged 8 commits into from
Dec 17, 2024
Merged

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Dec 11, 2024

Description

This PR introduces a worker that associates a lock address with a pending event upon successful deployment. This ensures a newly created event is properly updated with the relevant lock details.

Issues

Fixes #
Refs #15243

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 December 11, 2024 14:21
@cla-bot cla-bot bot added the cla-signed label Dec 11, 2024
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unlock-storybook ⬜️ Ignored (Inspect) Dec 17, 2024 9:46am

@0xTxbi 0xTxbi merged commit 5d22f91 into master Dec 17, 2024
15 checks passed
@0xTxbi 0xTxbi deleted the event-deployment-worker branch December 17, 2024 10:29
blahkheart pushed a commit to blahkheart/unlock that referenced this pull request Dec 21, 2024
* add event deployment worker

* worker registration

* refactor locks job

* update worker entry

* update worker structure for clarity

* send email after updating event status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants