feature(locksmith): Decouple event creation from user connection state #15249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTxbi
force-pushed
the
async-event-creation
branch
from
fb4c227 to
94279c0
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
0xTxbi
changed the title
julien51
reviewed
Dec 16, 2024
| // This was a creation! | ||
| if (created) { | ||
| // Only send email if event is deployed | ||
| if (created && event.status === EventStatus.DEPLOYED) { |
There was a problem hiding this comment.
ok let's make sure the email is still sent after it was deployed when this is happening later
julien51
approved these changes
Dec 16, 2024
blahkheart
pushed a commit
to blahkheart/unlock
that referenced
this pull request
Dec 21, 2024
unlock-protocol#15249) * update model * add migration script * add event deployment status to types package * update event operations * update event controller * update event route * update unlockjs package * draft dashboard utilisation * update unlockjs * update operation * update controller * update model * update route * remove types * update controller * remove deprecated function * update controller * cleanup * remove deployment queue * linting * more cleanup * update to use package types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a more reliable process for event creation by decoupling it from the user’s connection state during lock deployment. The previous implementation depended on the user witnessing the deployment, which was fragile in cases of disconnection or tab closure. The updated logic ensures events are consistently created regardless of the user’s connection status.
Issues
Fixes #15243
Refs #15243
Checklist: