Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(locksmith): Remove Coinbase WaaS support in locksmith #15247

Merged
merged 7 commits into from
Dec 5, 2024
Merged

feature(locksmith): Remove Coinbase WaaS support in locksmith #15247

merged 7 commits into from
Dec 5, 2024

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Dec 5, 2024 •
edited
Loading

Description

This PR introduces the removal of support for the Coinbase WaaS API in locksmith.

Issues

Fixes #15236
Refs #15236

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 December 5, 2024 14:22
@cla-bot cla-bot bot added the cla-signed label Dec 5, 2024
julien51
julien51 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@0xTxbi 0xTxbi merged commit 6f47f19 into master Dec 5, 2024
14 checks passed
@0xTxbi 0xTxbi deleted the locksmith-coinbase-waas-cleanup branch December 5, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien51 julien51 julien51 approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Coinbase WAAS API handling
2 participants
@0xTxbi @julien51