JavaScript: capture function objects in Self-Invoking Anonymous Function Statements #2005
Conversation
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't really fancy having all this in parseLine() instead of parseStatement(), but I must admit that it's a lot easier that way, so why not.
There was a problem hiding this comment.
..I recognize putting all new code to parseLine is not good.
At least I should introduce a new function to handle (function ()...).
I will update my patch.
|
..I recognize putting all new code to parseLine is not good.
At least I should introduce a new function to handle |(function ()...)|.
My remark was simply that this is the kind of things a function called
`parseStatement()` should do, but as it currently is `parseStatement()`
is way too complex and fragile to allow adding this easily, so your
change is probably fine.
I'm not sure it's worth it or if having another function would be
clearer, but if you think so, go ahead :)
|
|
Sorry to be late. During working on improving my change, I found some inputs the parser doesn't work well. |
masatake
force-pushed
the
js-self-invoking-anon-func
branch
from
54f8b9a to
857ef27
Compare
masatake
force-pushed
the
js-self-invoking-anon-func
branch
from
857ef27 to
c4848c4
Compare
I cannot remember the inputs. |
Codecov Report
@@ Coverage Diff @@
## master #2005 +/- ##
=======================================
Coverage 83.35% 83.35%
=======================================
Files 218 218
Lines 52510 52538 +28
=======================================
+ Hits 43769 43795 +26
- Misses 8741 8743 +2
Continue to review full report at Codecov.
|
masatake
force-pushed
the
js-self-invoking-anon-func
branch
from
c4848c4 to
d0ed6dc
Compare
…ion Statements Signed-off-by: Masatake YAMATO <[email protected]>
masatake
force-pushed
the
js-self-invoking-anon-func
branch
from
d0ed6dc to
2973fa8
Compare
|
#3437 is a much better solution. |
Signed-off-by: Masatake YAMATO [email protected]