Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[US-684] Example for Report From CSV #259

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

kellemNegasi
Copy link
Contributor

No description provided.

@kellemNegasi kellemNegasi changed the title [US-684] Initial Example for Report From CSV [US-684] Example for Report From CSV Oct 11, 2024
@kellemNegasi kellemNegasi marked this pull request as ready for review October 11, 2024 11:39
Copy link
Contributor

@anovik anovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, could you please address several comments?

report/README.md Outdated Show resolved Hide resolved
report/pdf_report_from_csv.go Show resolved Hide resolved
report/pdf_report_from_csv.go Outdated Show resolved Hide resolved
@kellemNegasi kellemNegasi requested a review from anovik October 11, 2024 13:28
Copy link
Contributor

@sampila sampila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@3ace 3ace merged commit 28eaf65 into unidoc:master Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants