CLDR-17366 kbd: rename unicodeSet to uset
#3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
previously requested changes
Feb 7, 2024
srl295
force-pushed
the
srl295/kbd/cldr-17366-uset
branch
from
839f560 to
0994900
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
macchiati
requested changes
Feb 7, 2024
mcdurdin
changed the title
unicodeSet to uset
macchiati
approved these changes
Feb 8, 2024
See unicode-org#3496 - keyboard 3 needs to be from start version 45.0, otherwise tests incorrectly attempt stability with v44.
srl295
force-pushed
the
srl295/kbd/cldr-17366-uset
branch
from
ed98d95 to
2d4ced1
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
srl295
dismissed
mcdurdin’s stale review
I've addressed the request to go with lowercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17366
ALLOW_MANY_COMMITS=true