CLDR-17177 kbd: update per feedback #3495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to land #3445 before this, this will need a rebase eventually. |
mcdurdin
reviewed
Feb 7, 2024
mcdurdin
reviewed
Feb 7, 2024
macchiati
requested changes
Feb 7, 2024
This was referenced Feb 7, 2024
|
@macchiati what's outstanding before this can merge? (The DTD is split off to a separate ticket) |
1 task
|
@macchiati any objection to this one? |
srl295
force-pushed
the
srl295/kbd/cldr-17177/mdfeedback
branch
from
dfa3c99 to
4041bfd
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
Can I get a review on this? |
|
how did this diverge so? okay.. |
macchiati
requested changes
Feb 27, 2024
|
sounds good
On Tue, Feb 27, 2024 at 3:25 PM Steven R. Loomis ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/ldml/tr35-keyboards.md
<#3495 (comment)>:
> @@ -306,19 +308,18 @@ Attribute values escaped in this manner are annotated with the ***@***.***_UESC
## File and Directory Structure
-* New collection of layouts that are prescriptive, and define the common core for a keyboard that can be consumed as data for implementation on different platforms will be included in the CLDR repository. This collection will be in a different location than the existing CLDR keyboard files under main/keyboards. We should remove the existing data files, but keep the old DTD in the same place for compatibility, and also so that conversion tools can use it to read older files.
-* New layouts will have version metadata to indicate their specification compliance version number. For this tech preview, the value used must be `techpreview`.
-
-```xml
-<keyboard3 conformsTo="techpreview"/>
-```
+* In the future, new layouts will be included in the CLDR repository, as a way for new layouts to be distributed in a cross-platorm manner. The process for this repository of layouts has not yet been defined, see [CLDR-17253](https://unicode-org.atlassian.net/browse/CLDR-17253) for up-to-date information.
I'll change to point to the keyboard WG page
—
Reply to this email directly, view it on GitHub
<#3495 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMDHZ6MVLLONDYYS373YVZTNVAVCNFSM6AAAAABC44R6BOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBVGAYDGNBWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
macchiati
approved these changes
Feb 28, 2024
|
Merge conflicts. Will have to rebase.
|
- documented 'implementation' - added a Notation section - corrections to discussion of repository and file layout
- fixed 'represents'
Co-authored-by: Marc Durdin <[email protected]>
- ... to … - some additional clarifications
- see CLDR-17371 for the PR to actually change the tooling to support this
Co-authored-by: Mark Davis <[email protected]>
- removed CLDR-#### issue links
srl295
force-pushed
the
srl295/kbd/cldr-17177/mdfeedback
branch
from
edef205 to
62c454a
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
Rebased with no change. Can I get an approval? |
miloush
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17177
ALLOW_MANY_COMMITS=true