Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16604 kbd: complete scancode data #3276

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Sep 20, 2023

CLDR-16604

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

- Also adds 'ks' as per CLDR-16873
@srl295 srl295 requested review from miloush and a team September 20, 2023 19:14
@srl295 srl295 self-assigned this Sep 20, 2023
@srl295 srl295 requested a review from a team September 20, 2023 19:14
@miloush
Copy link
Contributor

miloush commented Sep 21, 2023

Note that if you map keys from the left, iso=abnt2=jis and us=ks, with the only difference being 56 next to left shift. So currently we have two physical arrangements, either with or without that key.

@srl295 srl295 merged commit f16d666 into unicode-org:main Sep 21, 2023
4 of 5 checks passed
@srl295 srl295 deleted the cldr-16873/kbd/add-ks branch September 21, 2023 15:08
@srl295
Copy link
Member Author

srl295 commented Sep 21, 2023

Note that if you map keys from the left, iso=abnt2=jis and us=ks, with the only difference being 56 next to left shift. So currently we have two physical arrangements, either with or without that key.

  • iso=abnt2=jis - jis has the extra 7d on the top row, iso doesn't have 73 on the fourth row
  • us = ks: ks only has the extra 7d vs what us has.

@miloush
Copy link
Contributor

miloush commented Sep 21, 2023

@srl295 what I mean is that they behave identical when the keys are not used, so technically there doesn't need to be that many forms defined. For example, you could have a form with 14 scancodes defined in the first row (13 on second, 12 on third and fourth), and <row> for the first row will have either 13 keys or 14 keys, it doesn't matter. (And to push it further, we could define a blank key and then have everyone use one prescribed form that includes 56 and not worry about forms, and/or make them think what a keyboard that has the key should do.)

It is important to have overridable/custom forms though, so nothing needs to change, it is just an observation. There is no harm in specifying them all individually explicitly.

@srl295
Copy link
Member Author

srl295 commented Sep 21, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants