Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: larger open area #957

Merged

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Nov 18, 2024

Correcting the interaction areas of some components of Ref and Card type. Plus the symbols for file and folder.

also updated uui-text so the specific class query can be used without the uui-text set on a parent node.

A few of them was not changed, not relevant at this point. But all node-refs and then Media/content-Node/user cards have been updated.

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-957.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe changed the title V1: larger open area Feat: larger open area Nov 18, 2024
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) November 18, 2024 12:35
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-957.westeurope.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-957.westeurope.azurestaticapps.net

1 similar comment
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-957.westeurope.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-957.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe merged commit 88c2c1a into v1/contrib Nov 19, 2024
10 of 11 checks passed
@nielslyngsoe nielslyngsoe deleted the v1/feature/larger-open-area-when-not-selectable branch November 19, 2024 10:24
nielslyngsoe added a commit that referenced this pull request Nov 20, 2024
* correct uui file symbol

* make open-part grow when not selectable

* revert lines

* correct card selection area

* correct ref-node selection area

* make uui text style available without use of uui-text

* update symbols

* revert

* update media card

* adapt user card

* always grow content node card open area

* adjust user card
@nielslyngsoe nielslyngsoe added the accessibility A11Y improvements label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility A11Y improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants