Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Input: set to flex grow #950

Merged

Conversation

nielslyngsoe
Copy link
Member

Make the control part of the uui-input flex-grow.

This will fix case where the input is set to min-width and the content of the input is not that wide, leaving some space that cannot be interacted with. — this change makes the input-element fill all the way, but still leaving room for event append or prepend slotted items.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) November 8, 2024 21:11
Copy link

sonarqubecloud bot commented Nov 8, 2024

Copy link

github-actions bot commented Nov 8, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-950.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe merged commit 5a1620f into v1/contrib Nov 18, 2024
11 of 12 checks passed
@nielslyngsoe nielslyngsoe deleted the v1/feature/uui-input-make-control-element-grow branch November 18, 2024 11:19
@nielslyngsoe nielslyngsoe added the enhancement New feature or request label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants