Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Accept 'for' as a direct element reference #802

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix: Accept 'for' as a direct element reference #802

merged 2 commits into from
May 24, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented May 24, 2024 •
edited
Loading

Setting for as the element to use as scope was broken for some reason, but this PR fixes it :-)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) May 24, 2024 07:51
@iOvergaard iOvergaard added the bug Something isn't working label May 24, 2024
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-802.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe merged commit e2b9efa into v1/contrib May 24, 2024
9 of 10 checks passed
@nielslyngsoe nielslyngsoe deleted the v1/bugfix/validation-message-when-for-is-element branch May 24, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielslyngsoe @iOvergaard