Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(uui-menu-item): focus method for menu-item #789

Merged
merged 1 commit into from
May 23, 2024
Merged

feat(uui-menu-item): focus method for menu-item #789

merged 1 commit into from
May 23, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Apr 22, 2024 •
edited
Loading

What it says :-)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) April 22, 2024 13:07
@nielslyngsoe nielslyngsoe mentioned this pull request Apr 22, 2024
Merged
7 tasks
@nielslyngsoe nielslyngsoe requested a review from iOvergaard April 24, 2024 10:43
@iOvergaard iOvergaard disabled auto-merge May 23, 2024 13:11
@iOvergaard iOvergaard changed the title focus method for menu-item feat(uui-menu-item): focus method for menu-item May 23, 2024
@iOvergaard iOvergaard added the feature Something we are looking to build label May 23, 2024
@iOvergaard iOvergaard merged commit 86062ae into v1/contrib May 23, 2024
10 of 12 checks passed
@iOvergaard iOvergaard deleted the feature/menu-item-focus branch May 23, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
feature Something we are looking to build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielslyngsoe @iOvergaard