Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uui-tab-group flex gap story #708

Closed
wants to merge 1 commit into from

Conversation

julczka
Copy link
Contributor

@julczka julczka commented Jan 17, 2024

This PR adds a story that reproduces a specific use case of uui-tabs from Cloud Portal, where tabs are used with a spacing between them. 1.6.0-rc3 version does not support that and it breaks the layout.

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

This is to illustrate an issue #707

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-708.westeurope.azurestaticapps.net

@JesmoDev
Copy link
Contributor

This branch can be removed as it has been merged into this branch: #712 which fixes the issues on #707

@nielslyngsoe
Copy link
Member

Closing this PR as its part of #712

@iOvergaard iOvergaard deleted the fix/tabs-do-not-support-flex-gap branch July 26, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants