Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modal close animation #702

Merged
merged 13 commits into from
Jan 23, 2024
Merged

Fix modal close animation #702

merged 13 commits into from
Jan 23, 2024

Conversation

JesmoDev
Copy link
Contributor

@JesmoDev JesmoDev commented Jan 10, 2024 •
edited
Loading

The modal container needs to know when a modal is closing (starting it's closing animation) so that it can update the rest of the modals and fade the backdrops. However because of a recent removal of the bubbling on the close event on the modal element, this is no longer happening.

This PR fixes that by setting up eventListeners on all child modals in the modal container.

Also fixes some timing issues that prevented the animation from firing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@JesmoDev JesmoDev marked this pull request as draft January 10, 2024 03:39
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-702.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-702.westeurope.azurestaticapps.net

@JesmoDev JesmoDev requested a review from nielslyngsoe January 10, 2024 04:02
@JesmoDev JesmoDev marked this pull request as ready for review January 10, 2024 04:11
@JesmoDev JesmoDev marked this pull request as draft January 11, 2024 02:21
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-702.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-702.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-702.westeurope.azurestaticapps.net

@JesmoDev JesmoDev marked this pull request as ready for review January 11, 2024 03:13
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-702.westeurope.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-702.westeurope.azurestaticapps.net

@JesmoDev JesmoDev added the bug Something isn't working label Jan 11, 2024
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-702.westeurope.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-702.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) January 23, 2024 09:43
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-702.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-702.westeurope.azurestaticapps.net

nielslyngsoe
nielslyngsoe approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-702.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe merged commit 4552287 into v1/contrib Jan 23, 2024
9 of 10 checks passed
@nielslyngsoe nielslyngsoe deleted the bugfix/modal-close-animation branch January 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JesmoDev @nielslyngsoe