Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/tab group #677

Merged
merged 13 commits into from
Dec 1, 2023
Merged

Bugfix/tab group #677

merged 13 commits into from
Dec 1, 2023

Conversation

JesmoDev
Copy link
Contributor

@JesmoDev JesmoDev commented Nov 30, 2023 •
edited
Loading

UUITab:

  • Removed unused background color cssvar
  • Added missing styling for active cssvar

UUITabGroup:

  • added following cssvars:
    • @cssprop --uui-tab-group-dropdown-tab-text - Define the tab text color in the dropdown
    • @cssprop --uui-tab-group-dropdown-tab-text-hover - Define the tab text hover color in the dropdown
    • @cssprop --uui-tab-group-dropdown-tab-text-active - Define the tab text active color in the dropdown
    • @cssprop --uui-tab-group-dropdown-background - Define the background color of the dropdown
  • fixes issue with async tabs not showing properly
  • adds better default styling for the "more" button

@JesmoDev JesmoDev mentioned this pull request Nov 30, 2023
Merged
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-677.westeurope.azurestaticapps.net

@JesmoDev JesmoDev marked this pull request as ready for review November 30, 2023 06:56
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-677.westeurope.azurestaticapps.net

@JesmoDev JesmoDev marked this pull request as draft November 30, 2023 07:04
@JesmoDev JesmoDev removed the request for review from nielslyngsoe November 30, 2023 07:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-677.westeurope.azurestaticapps.net

@JesmoDev JesmoDev marked this pull request as ready for review December 1, 2023 04:44
@JesmoDev JesmoDev requested a review from nielslyngsoe December 1, 2023 04:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-677.westeurope.azurestaticapps.net

nielslyngsoe
nielslyngsoe approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, And great with the right amount of customizations!

@nielslyngsoe nielslyngsoe merged commit cb0414e into v1/contrib Dec 1, 2023
9 of 10 checks passed
@nielslyngsoe nielslyngsoe deleted the bugfix/tab-group branch December 1, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JesmoDev @nielslyngsoe