Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uui-menu-item: add flatten css var to hide chevron column #665

Merged
merged 5 commits into from
Nov 22, 2023
Merged

uui-menu-item: add flatten css var to hide chevron column #665

merged 5 commits into from
Nov 22, 2023

Conversation

JesmoDev
Copy link
Contributor

@JesmoDev JesmoDev commented Nov 22, 2023 •
edited by TheRealArtonn
Loading

Adds a css var: --uui-menu-item-flat-structure to menu item to remove the indentation of the chevron for when you know you won't have nesting (a flat structure)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@JesmoDev JesmoDev changed the title remove grid column on flatten Menu Item: add flatten css var to hide chevron column Nov 22, 2023
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-665.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-665.westeurope.azurestaticapps.net

@JesmoDev JesmoDev marked this pull request as ready for review November 22, 2023 09:47
@JesmoDev JesmoDev requested a review from iOvergaard November 22, 2023 09:47
iOvergaard
iOvergaard approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iOvergaard iOvergaard added the enhancement New feature or request label Nov 22, 2023
@iOvergaard iOvergaard changed the title Menu Item: add flatten css var to hide chevron column uui-menu-item: add flatten css var to hide chevron column Nov 22, 2023
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-665.westeurope.azurestaticapps.net

@iOvergaard iOvergaard merged commit cec3188 into v1/contrib Nov 22, 2023
9 of 10 checks passed
@iOvergaard iOvergaard deleted the feature/flat-menu-items branch November 22, 2023 09:49
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-665.westeurope.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JesmoDev @iOvergaard