Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check whether API supports requested bit-depth #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

farindk
Copy link
Contributor

@farindk farindk commented Nov 25, 2024

This adds the check to kvz_api_get(bit_depth) whether the requested bit depth is supported.
See #399

@Jovasa
Copy link
Member

Jovasa commented Nov 25, 2024

The 10bit kvazaar does support bitdepths <= 10, so LTE check is more appropriate than inequality check

@farindk
Copy link
Contributor Author

farindk commented Nov 25, 2024

I just tried 8bit encoding when setting KVZ_BIT_DEPTH=10.

The problem with that is that when the bit-depth is set to 10, it assumes that the input image is 2 bytes per pixel even if we use kvz_api_get(8). That's a bit unfortunate. A client that wants to encode 8 bit would then have to query if 10 bits is supported and depending on that it has to change the input image.

@Jovasa
Copy link
Member

Jovasa commented Nov 25, 2024

I fully agree with your concern, the main issue is that this change would break existing behaviour.

@fador opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants