Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish.yml #33

Merged
merged 3 commits into from
Jan 14, 2024
Merged

Fix publish.yml #33

merged 3 commits into from
Jan 14, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 14, 2024

Thank you 🙏 for your contribution to Ultralytics 🚀! Your effort in enhancing our repositories is greatly appreciated. To streamline the process and assist us in integrating your Pull Request (PR) effectively, please follow these steps:

  1. Check for Existing Contributions: Before submitting, kindly explore existing PRs to ensure your contribution is unique and complementary.

  2. Link Related Issues: If your PR addresses an open issue, please link it in your submission. This helps us better understand the context and impact of your contribution.

  3. Elaborate Your Changes: Clearly articulate the purpose of your PR. Whether it's a bug fix or a new feature, a detailed description aids in a smoother integration process.

  4. Ultralytics Contributor License Agreement (CLA): To uphold the quality and integrity of our project, we require all contributors to sign the CLA. Please confirm your agreement by commenting below:

    I have read the CLA Document and I hereby sign the CLA

For more detailed guidance and best practices on contributing, refer to our ✅ Contributing Guide. Your adherence to these guidelines ensures a faster and more effective review process.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhancements to the Python environment setup and version checking in the publish workflow for a MkDocs plugin.

📊 Key Changes

  • 🔣 Uncomments and sets the Python version to 3.11 for the workflow environment.
  • 🔄 Simplifies version extraction from pyproject.toml with improved variable naming.
  • ✨ Switches from shell echo commands to Python's os.system calls for environment variable setting.

🎯 Purpose & Impact

  • 🐍 Ensures compatibility with Python 3.11, potentially improving performance and leveraging new language features.
  • 🧹 Code cleanup for better readability and maintainability in the version check logic.
  • 📈 More robust environment variable setting within the GitHub Action, which could prevent potential bugs and streamline the CI/CD process.
  • 📦 Users can expect more reliable updates and packaging for the MkDocs plugin, enhancing the documentation experience.

@glenn-jocher glenn-jocher changed the title Update publish.yml Fix publish.yml Jan 14, 2024
@glenn-jocher glenn-jocher merged commit 7e07bf8 into main Jan 14, 2024
2 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch January 14, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant