Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpreter only on LHS #508

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from
Open

Interpreter only on LHS #508

wants to merge 30 commits into from

Conversation

nikivazou
Copy link
Member

No description provided.

michaelborkowski and others added 25 commits May 7, 2021 08:39
@michaelborkowski
For now, disable old PLE and eta elimination. The command line flags
0c880b7 
will no longer have any effect.
@michaelborkowski
First attempt at Guarded Expressions representation of reflected
d0fdb99 
functions in PLE
@michaelborkowski
tree-structured guards approach to new ple-unfold
132c672
@michaelborkowski
Fixing parse-ability of .fq files, mostly by improving toFix
bcbd4f0
@michaelborkowski
Cleanup unused code
f94e4e0
@michaelborkowski
convert knAms and knSims to HashMaps to change O(n) searches to O(log n)
c965733 
remove redundant code in evalApp
@michaelborkowski
checking in interpreter in progress
deda7f2
@michaelborkowski
Remove all the Guarded Equations (GEqns) code, it's not needed anymore
8ce0988
@michaelborkowski
Corrections for removal of guarded equations
74ccedc
@michaelborkowski
Cleanup code
4625fd3
@michaelborkowski
Fixed the compiler warnings
ccc93d4
@michaelborkowski
Merge branch 'develop' into PLEunfold
41f0bea
@michaelborkowski
Merge commit '8b1b48b0' into PLEunfold
93130bc
@michaelborkowski
additional work
49d88e0
@michaelborkowski
fix compiler warnings
6223729
@michaelborkowski
add a CL flag for the interpreter
3b9af40
@michaelborkowski
fix failing test?
d28e0cb
@michaelborkowski
Change comment for haddock
a74ec62
@michaelborkowski
Merge branch 'develop' into PLEunfold
307fe74
@michaelborkowski
Merge branch 'PLEunfold' of https://github.com/ucsd-progsys/liquid-fi…
d22876d 
…xpoint into PLEunfold
@michaelborkowski
Fix compiler errors post-merge
7770831
@michaelborkowski
Remove debug code, most unused code
7c45783
@michaelborkowski
Clean up comments, port PLE improvements
0a85a62
@nikivazou
redo interpreter
46c23aa
@nikivazou
restore PLE
3755309
@nikivazou nikivazou mentioned this pull request Nov 10, 2021
Open
@facundominguez facundominguez mentioned this pull request Nov 13, 2021
Closed
@facundominguez
Copy link
Collaborator

@nikivazou is this something worth pursuing to completion now the the interpreter has been merged?

I lack some context to be sure, but two things seem to be happening in this PR that look worth finishing: Firstly, code duplication in PLE and the interpreter is factored out. Secondly, there is an attempt to simplify the interpreter by discarding the Trie that PLE uses, and instead going with a smaller procedure (maybe you can give an overview of the differences).

@nikivazou
Copy link
Member Author

Exactly! There is the refactoring and code is much simpler. But this interpreter is not strong enough for @michaelborkowski 's case study to pass.
So, my suggestion is to leave it hugging until I find time to improve it to handle the case study...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP: Don't Merge Yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikivazou @facundominguez @michaelborkowski