-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment support. #48
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
============================================
- Coverage 90.14% 87.08% -3.06%
- Complexity 406 408 +2
============================================
Files 66 66
Lines 2211 2384 +173
Branches 432 481 +49
============================================
+ Hits 1993 2076 +83
- Misses 125 183 +58
- Partials 93 125 +32
Continue to review full report at Codecov.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs, but feel free to re-open a closed issue if needed. |
@Cybermaxke Are you still interested in adding this feature? I'm on the hunt (again) for a configuration library and this is one of the things stopping me from using konf. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs, but feel free to re-open a closed issue if needed. |
@Cybermaxke I'm in the same position as @Prof-Bloodstone. Konf so far is the only lib I can find that meets my requirements, and I'd really love for this feature to be added. |
@solonovamax I'm not planning to work on this anytime soon, so feel free to continue working on it. |
Alright, I'll take a look at it. 👍 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs, but feel free to re-open a closed issue if needed. |
chore: Clean up grammar and code style across the entire codebase.
I've integrated this PR into my fork of Konf. |
Adds support that descriptions of
Item
s are added to saved configuration files. This is useful when auto-generating configuration files. Persisting custom comments between load and write isn't supported.TODO:
Xmlthe current output structure isn't optimal for commentsGiven the following example:
Outputs: