Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog:added adding BINARY_ARGS to the sim log name to allow concurrent pk sims #2096

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

miles-rusch-berkeley
Copy link

adding BINARY_ARGS to the sim log name (for use with pk). This way pk sims with different argv inputs can be executed at a time, logging to different directories.

Related PRs / Issues:

Type of change:

  • Bug fix
  • [ x ] New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • [ x ] Build system change
  • Other

Contributor Checklist:

  • [ x ] Did you set main as the base branch?
  • [ x ] Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • [ x ] Did you state the type-of-change/impact?
  • [ x ] Did you delete any extraneous prints/debugging code?
  • [ x ] Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See ci:* for full list of labels:

  • ci:fpga-deploy - Run FPGA-based E2E testing
  • ci:local-fpga-buildbitstream-deploy - Build local FPGA bitstreams for platforms that are released
  • ci:disable - Disable CI

Copy link
Contributor

@joonho3020 joonho3020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clean this up so that instead of fixing the existing run-binary we can have run-binary-args, run-binary-args-debug?

Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break run-binaries.

Running with PK shouldn't be a frequently required operation anyways, IMO

run-binaries: check-binaries $(addsuffix .run,$(BINARIES))

%.run: %.check-exists $(SIM_PREREQ) | $(output_dir)
%.run: $(BINARY).check-exists $(SIM_PREREQ) | $(output_dir)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing % with $(BINARY) breaks run-binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants