-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changelog:added adding BINARY_ARGS to the sim log name to allow concurrent pk sims #2096
base: main
Are you sure you want to change the base?
changelog:added adding BINARY_ARGS to the sim log name to allow concurrent pk sims #2096
Conversation
adding BINARY_ARGS to the sim log name for use with pk. This way multiple pk runs can be executed at a time, logging to different directories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clean this up so that instead of fixing the existing run-binary
we can have run-binary-args
, run-binary-args-debug
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break run-binaries
.
Running with PK shouldn't be a frequently required operation anyways, IMO
run-binaries: check-binaries $(addsuffix .run,$(BINARIES)) | ||
|
||
%.run: %.check-exists $(SIM_PREREQ) | $(output_dir) | ||
%.run: $(BINARY).check-exists $(SIM_PREREQ) | $(output_dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing %
with $(BINARY)
breaks run-binaries
.
adding BINARY_ARGS to the sim log name (for use with pk). This way pk sims with different argv inputs can be executed at a time, logging to different directories.
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See
ci:*
for full list of labels:ci:fpga-deploy
- Run FPGA-based E2E testingci:local-fpga-buildbitstream-deploy
- Build local FPGA bitstreams for platforms that are releasedci:disable
- Disable CI