Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import package set from ros-o-builder #16

Closed
wants to merge 3 commits into from
Closed

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Oct 16, 2024

As discussed before, here is the patch for the in total 1009 packages building successfully for jammy in https://github.com/v4hn/ros-o-builder/blob/jammy-one/README.md

For the debian-based builds I use these additional rosdep keys for now.
I don't know how many of these you will need as well, if any, as most just remap to native debian packages.

jsk-ros-pkg/jsk_3rdparty#509 lists the remaining few failures in the JSK stack.
I would still prefer to keep the JSK repositories included here because jsk_visualization (with rviz and qt plugins) builds and has cross-references with the other repositories.

Please look through the individual entries to decide on a case-by-case basis whether you also want to, e.g., use upstream for ruckig and ompl instead of the release versions.

I would appreciate it if we can keep the .git suffix consistently to ease future merge efforts.

rhaschke and others added 3 commits October 16, 2024 16:17
So far, we skipped rebuilding a package if it didn't change.
However, we also need to consider any upstream changes.
Few packages in the jsk stacks are still expected to fail,
but will hopefully get resolved in the future.
@rhaschke
Copy link
Member

Merged via 2fa8605

@rhaschke rhaschke closed this Oct 17, 2024
@rhaschke
Copy link
Member

@v4hn
Copy link
Contributor Author

v4hn commented Oct 17, 2024

You are right, eigenpy crashes with the default 4 jobs, but it builds well in the current runners with 3 jobs.
I added a hook in my job allocation to reduce the jobs: https://github.com/v4hn/ros-o-builder/blob/build-for-jammy/scripts%2Fgenerate-jobs.py#L11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants