feat(container): add self registration of container in constructor, t… #101
Conversation
…est, and document it
|
Thank your for the PR, I'll take a look tomorrow. You can try implementing this one , |
src/lib/container.interface.ts
Outdated
| @@ -6,6 +6,8 @@ export interface IContainerOptions { | |||
| } | |||
|
|
|||
| export interface IContainer { | |||
| [key: string]: any; | |||
There was a problem hiding this comment.
Doing that it's a bad practise. Interface (aka super type) should define only public methods. Unless you use interface for defining structure of value objects. Please remove that.
src/lib/container.ts
Outdated
| @@ -21,6 +21,7 @@ export class Container implements IContainer { | |||
| this.parent = <IContainer> options.parent; | |||
| this.defaultLifeTime = options.defaultLifeTime || this.defaultLifeTime; | |||
| } | |||
| this.register({ token: TContainer, useValue: this }); | |||
There was a problem hiding this comment.
You did right! But I'm gonna release that simplified Reflect API which is gonna allow us to inject stuff by just specifying it's type like this constructor (private container: Container) {}. Please use Container as the token in this case.
src/tests/container.spec.ts
Outdated
| it('should register itself for injection', () => { | ||
| // arrange, act | ||
| const actual = container.resolve(TContainer); | ||
| // assert |
There was a problem hiding this comment.
You can't deny that comments like this one are obvious. Clearly named variables and methods won't need any comments above them. Please remove them.
|
@Tolowe Tt's better to just close this PR, then pull changes and then fix yours and open new PR. |
|
@ThoHoh I think I have everything fixed as you mentioned. |
|
@Tolowe Thank you! |
…est, and document it