Pull: turn flatMapOutput into an extension method. #3016
Conversation
diesalbla
force-pushed
the
flatmapoutput_as_method
branch
from
a26e2f1 to
d67bd7c
Compare
| @@ -962,6 +962,8 @@ final class Stream[+F[_], +O] private[fs2] (private[fs2] val underlying: Pull[F, | |||
| queue: Queue[F2, Option[Chunk[O2]]] | |||
| ): Stream[F2, Nothing] = enqueueNoneTerminatedChunks(queue: QueueSink[F2, Option[Chunk[O2]]]) | |||
|
|
|||
| import Pull.StreamPullOps | |||
There was a problem hiding this comment.
Why is the import necessary, is it not in implicit scope automatically?
There was a problem hiding this comment.
Failed to compile in Scala 3 without it. It could be that Scala 3 has narrowed that scope.
| private[fs2] def flatMapOutput[F[_], F2[x] >: F[x], O, O2]( | ||
| p: Pull[F, O, Unit], | ||
| f: O => Pull[F2, O2, Unit] | ||
| ): Pull[F2, O2, Unit] = | ||
| p match { | ||
| case a: AlgEffect[F, Unit] => a | ||
| case r: Terminal[_] => r | ||
| case _ => FlatMapOutput(p, f) | ||
| } |
There was a problem hiding this comment.
Instead of adding a MiMa filter, can we just make this deprecated and delegate it to the new implementation?
There was a problem hiding this comment.
Hmmmm if it is a private[fs2] method, how could a binary incompatibility happen?
There was a problem hiding this comment.
It's because of scala/scala3#10842.
It would be safe to add a filter, but every filter we add risks accidentally masking a real issue. So my personal preference is to avoid filters even for private stuff if there's an easy fix.
There was a problem hiding this comment.
Not ideal, but so be it. Added back.
diesalbla
force-pushed
the
flatmapoutput_as_method
branch
from
d67bd7c to
45766d0
Compare
We may like method calls, even extension methods, better than functions. Plus, we need fewer type arguments in the calls.
diesalbla
force-pushed
the
flatmapoutput_as_method
branch
from
5d5911b to
d95cd67
Compare
We may like method calls, even extension methods, better than functions. Plus, we need fewer type arguments in the calls.