Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to sbt-typelevel-ci-release #597

Merged
merged 8 commits into from
Jan 26, 2022

Conversation

armanbilge
Copy link
Member

(Opening for CI, will update later.)

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #597 (2d875f7) into master (b3ba711) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          65       65           
  Lines        1134     1134           
  Branches        5       11    +6     
=======================================
  Hits         1079     1079           
  Misses         55       55           
Flag Coverage Δ
2.12.15 95.14% <ø> (ø)
2.13.8 95.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ba711...2d875f7. Read the comment docs.

@armanbilge
Copy link
Member Author

@pomadchin thanks for your support, seems to be working! The good news was I was able to split your CI into parallel jobs so it should run a lot faster now 😁

I think this PR should be ready for review, let me know if you have any questions.

@armanbilge armanbilge marked this pull request as ready for review January 24, 2022 17:02
@pomadchin
Copy link
Member

@armanbilge thx for your marvellous work! I'll take a look a bit later, but looks pretty cool; I hope all artifacts are correctly published, that was a nice 🤦 done by me originally.

Btw, what is the story with this plugin, it is a replacement for the sbt-ci-release plugin?

@armanbilge
Copy link
Member Author

I hope all artifacts are correctly published, that was a nice 🤦 done by me originally.

Yes, I studied that carefully before working on this PR. I think you may have had some minor misconfiguration that forced you to publish in two separate steps. I think that should be fixed now, but we'll have to try it to know for sure. Snapshots are enabled so it will be tested as soon as this PR is merged.

Btw, what is the story with this plugin, it is a replacement for the sbt-ci-release plugin?

You can find some information here:

We're trying to centralize all the Typelevel projects to use similar builds. This has many advantages:

  • All projects are now using correct versioning, MiMa settings, etc. Some projects didn't have this configured at all or had it configured incorrectly.
  • Contributors should have a very similar experience in every project and maintainers don't have to remember the quirks of each project since they all work the same :)
  • We can quickly update all the builds by publishing a new version of sbt-typelevel. For example, we want to change the publishing for org.typelevel to use the new sonatype infrastructure.
    Move org.typelevel to s01.oss.sonatype.org sbt-typelevel#84

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a great builds and CI runtime improvement. 🎉 thank you!

Merging it to test.

@pomadchin pomadchin merged commit 9a7df12 into typelevel:master Jan 26, 2022
@pomadchin pomadchin mentioned this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants