-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to sbt-typelevel-ci-release #597
Conversation
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 65 65
Lines 1134 1134
Branches 5 11 +6
=======================================
Hits 1079 1079
Misses 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@pomadchin thanks for your support, seems to be working! The good news was I was able to split your CI into parallel jobs so it should run a lot faster now 😁 I think this PR should be ready for review, let me know if you have any questions. |
@armanbilge thx for your marvellous work! I'll take a look a bit later, but looks pretty cool; I hope all artifacts are correctly published, that was a nice 🤦 done by me originally. Btw, what is the story with this plugin, it is a replacement for the sbt-ci-release plugin? |
Yes, I studied that carefully before working on this PR. I think you may have had some minor misconfiguration that forced you to publish in two separate steps. I think that should be fixed now, but we'll have to try it to know for sure. Snapshots are enabled so it will be tested as soon as this PR is merged.
You can find some information here: We're trying to centralize all the Typelevel projects to use similar builds. This has many advantages:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a great builds and CI runtime improvement. 🎉 thank you!
Merging it to test.
(Opening for CI, will update later.)