fix more bench warnings #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satorg
commented
Dec 14, 2022
| @@ -44,13 +44,13 @@ class BitSetBenchmarks { | |||
| var size: Int = _ | |||
| var indices: Array[Int] = _ | |||
|
|
|||
| var values: Array[Int] = _ | |||
| var values: Vector[Int] = _ | |||
There was a problem hiding this comment.
Starting with v2.13 the compiler complains when Array is passed as a vararg parameter (like immutable.BitSet(values: _*) ) because it involves an implicit conversion to Seq and hence the entire array gets copied for that.
Changing to Vector because it is already Seq so no conversion is necessary.
satorg
commented
Dec 14, 2022
| @@ -77,16 +77,16 @@ class DietAddBench extends BestCaseRangesList { | |||
|
|
|||
| @Benchmark | |||
| def scalazDievAdd(): Unit = { | |||
| scalazValues.foldLeft(Diev.empty[Int])((d, r) => d + r) | |||
| scalazValues.foldLeft(Diev.empty[Int])((d, r) => d + r): Unit | |||
There was a problem hiding this comment.
Scala complains here and below that a non-unit value gets discarded.
Ascribing the expression type to Unit helps to calm it down.
gemelen
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #486
Follow-up to #562
Somehow I overlooked some of the warnings in the bench module.