chore: Optimize Go caches in Github Actions #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we still need chezmoi/assets/chezmoi.io/docs/hooks.py Lines 35 to 39 in 938fdfd |
|
Thanks for the pointer! It actually works without it, but slower because of no cache. |
KapJI
force-pushed
the
go-cache
branch
7 times, most recently
from
02e9d0e to
1978bc7
Compare
|
@twpayne I fixed issue with Windows jobs. They are 3 times faster now. |
KapJI
commented
Nov 6, 2024
Comment on lines
-312
to
-317
| - uses: actions/cache@6849a6489940f00c2f30c0fb92c6274307ccb58a | ||
| with: | ||
| path: ~/go/pkg/mod | ||
| key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-go- |
There was a problem hiding this comment.
This was creating duplicating cache entry which also was super slow to unpack.
|
Awesome, thank you very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOPATH,GOCACHEandGOMODCACHEon Windows jobs. DriveC:/on Windows workers is extremely slow and now these jobs are as fast as on MacOS or Linux.test-windowsjob is down to 6m8s from 18m30s, 67% imrovement!lint-windows-2022is down to 58s from 3m10s, 70% improvement!codeqljob. Re-use cache key generated byactions/setup-go. Run time is improved from 2m19s to 1m49s, by ~22%.